chore: specify containerd version to install with moby-engine package #3723
Conversation
cpuguy83
force-pushed
the
containerd_pinning
branch
5 times, most recently
from
c2d2e71 to
60e77fa
Compare
Codecov Report
@@ Coverage Diff @@
## master #3723 +/- ##
==========================================
+ Coverage 73.16% 73.18% +0.01%
==========================================
Files 147 148 +1
Lines 25318 25352 +34
==========================================
+ Hits 18525 18553 +28
- Misses 5655 5663 +8
+ Partials 1138 1136 -2
Continue to review full report at Codecov.
|
Moby needs containerd, we should lock in a default version for this. Additionally this enables users to customize the containerd version to use along with moby.
This gets aks-engine up to date with what's we currently have available and updates the default to the latest.
This test cannot run in parallel due to the same `c.components` being re-used for different cases.
cpuguy83
force-pushed
the
containerd_pinning
branch
from
60e77fa to
25c6753
Compare
| @@ -37,7 +38,7 @@ var ( | |||
| "3.1.0", "3.1.1", "3.1.2", "3.1.2", "3.1.3", "3.1.4", "3.1.5", "3.1.6", "3.1.7", "3.1.8", "3.1.9", "3.1.10", | |||
| "3.2.0", "3.2.1", "3.2.2", "3.2.3", "3.2.4", "3.2.5", "3.2.6", "3.2.7", "3.2.8", "3.2.9", "3.2.11", "3.2.12", | |||
| "3.2.13", "3.2.14", "3.2.15", "3.2.16", "3.2.23", "3.2.24", "3.2.25", "3.2.26", "3.3.0", "3.3.1", "3.3.8", "3.3.9", "3.3.10", "3.3.13", "3.3.15", "3.3.18", "3.3.19", "3.3.22"} | |||
| containerdValidVersions = [...]string{"1.3.2"} | |||
| containerdValidVersions = [...]string{"1.3.2", "1.3.3", "1.3.4", "1.3.5", "1.3.6", "1.3.7"} | |||
There was a problem hiding this comment.
Can 1.4.0 also be allowed? If I understand correctly, even with this change I won't be able to use containerRuntime as containerd and version 1.4.0
There was a problem hiding this comment.
Working on it, but not at this time.
I am holding back 1.4 packages due some issues around how apt manages packages.
Basically, as soon as we upload containerd 1.4, when someone installs our moby packages they will get containerd 1.4 (unless they do what is being done here), which is an untested scenario.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpuguy83, mboersma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
mboersma
changed the title
Reason for Change:
Since moby packages now depend on a separate containerd package, we should specify which version of the containerd package should be picked up so that we don't accidentally introduce regressions for new installs/upgrades due to
apt-getpicking the latest containerd (which may include major version bumps).This also enables testing aks-engine with different versions of containerd (such as the newly released 1.4) since the api model now allows specifying a containerd version when the moby version is >= 19.03.
Issue Fixed:
N/A
Requirements:
Notes: