Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

test: run pod schedule tests first #3627

Merged
merged 1 commit into from
Jul 21, 2020

Conversation

jackfrancis
Copy link
Member

Reason for Change:

In response to a test flake that resulted from a Windows node not being able to schedule pods (but the test results not showing that explicitly), this PR adds a discrete "should be able to schedule a pod to a Windows node" test, and does all pod scheduling tests before running other tests that in fact depend upon pod scheduling.

Issue Fixed:

Requirements:

Notes:

@acs-bot acs-bot added the size/M label Jul 21, 2020
@jackfrancis
Copy link
Member Author

cc @jsturtevant

@acs-bot
Copy link

acs-bot commented Jul 21, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Jul 21, 2020

Codecov Report

Merging #3627 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3627   +/-   ##
=======================================
  Coverage   73.14%   73.14%           
=======================================
  Files         147      147           
  Lines       25165    25165           
=======================================
  Hits        18408    18408           
  Misses       5623     5623           
  Partials     1134     1134           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b06a18b...b25bb0a. Read the comment docs.

@jackfrancis jackfrancis merged commit e66fe7c into Azure:master Jul 21, 2020
@jackfrancis jackfrancis deleted the test-schedule-pods branch July 21, 2020 23:33
jackfrancis added a commit that referenced this pull request Jul 21, 2020
penggu pushed a commit to penggu/aks-engine that referenced this pull request Oct 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants