Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

docs: update throttling doc #3545

Merged
merged 8 commits into from
Jun 26, 2020

Conversation

jackfrancis
Copy link
Member

Reason for Change:

The original version of this document incorrectly stated that the kubelet systemd service was able to stop the controller-manager process. These updates provide working examples of how to actually stop kube-controller-manager (and/or cloud-controller-manager) during Azure API throttling events.

Issue Fixed:

Requirements:

Notes:

@jackfrancis jackfrancis requested review from aramase and mboersma June 25, 2020 22:07
mboersma
mboersma previously approved these changes Jun 25, 2020
Copy link
Member

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Just optional style comments.


Now, we can verify that v1.15.12 is the running `controller-manager` version:

```
azureuser@k8s-master-31453872-0:~$ for pod in $(kubectl get pods -n kube-system | grep kube-controller-manager | awk '{print $1}'); do kubectl logs $pod -n kube-system | grep "v1.15.12"; done
azureuser@k8s-master-31453872-0:~$ for pod in $(kubectl get pods -n kube-system -l component=kube-controller-manager | awk '{print $1}'); do kubectl logs $pod -n kube-system | grep "v1.15.12"; done
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@acs-bot
Copy link

acs-bot commented Jun 25, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis, mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jackfrancis,mboersma]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Member

@aramase aramase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@acs-bot
Copy link

acs-bot commented Jun 26, 2020

New changes are detected. LGTM label has been removed.

@jackfrancis jackfrancis merged commit 587b768 into Azure:master Jun 26, 2020
@jackfrancis jackfrancis deleted the docs-throttling-part-deux branch June 26, 2020 16:43
penggu pushed a commit to penggu/aks-engine that referenced this pull request Oct 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants