Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

fix: always use /var/run/reboot-required #3536

Merged
merged 1 commit into from
Jun 25, 2020

Conversation

jackfrancis
Copy link
Member

@jackfrancis jackfrancis commented Jun 24, 2020

Reason for Change:

This PR standardizes the CSE bootstrapping script to always evaluate [ -f /var/run/reboot-required ] (does the file exist?) to determine whether or not we need to reboot.

In addition, in the case where we want to reboot, we touch that file, which as far as I can tell is a safe tactic as /var/run is tmpfs and files therein will be reliably removed upon reboot. Cf:

azureuser@k8s-master-31453872-1:~$ ls -la /var/run
lrwxrwxrwx 1 root root 4 Nov 13  2019 /var/run -> /run
azureuser@k8s-master-31453872-1:~$ df -h /run
Filesystem      Size  Used Avail Use% Mounted on
tmpfs           796M  1.2M  795M   1% /run

Issue Fixed:

Fixes #3533

Requirements:

Notes:

@jackfrancis jackfrancis requested a review from mboersma June 24, 2020 20:19
@acs-bot acs-bot added the size/M label Jun 24, 2020
@jackfrancis
Copy link
Member Author

cc @MichaelSinz

@codecov
Copy link

codecov bot commented Jun 24, 2020

Codecov Report

Merging #3536 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3536   +/-   ##
=======================================
  Coverage   73.19%   73.19%           
=======================================
  Files         147      147           
  Lines       25079    25079           
=======================================
  Hits        18356    18356           
  Misses       5589     5589           
  Partials     1134     1134           
Impacted Files Coverage Δ
pkg/engine/templates_generated.go 54.08% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42b1317...74e1c58. Read the comment docs.

@Michael-Sinz
Copy link
Collaborator

Looks good to me.

Copy link
Member

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@acs-bot
Copy link

acs-bot commented Jun 25, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis, mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jackfrancis,mboersma]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jackfrancis jackfrancis merged commit 0219607 into Azure:master Jun 25, 2020
@jackfrancis jackfrancis deleted the reboot-required branch June 25, 2020 17:15
penggu pushed a commit to penggu/aks-engine that referenced this pull request Oct 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

improve reboot detection in CSE
4 participants