docs: supported versions for Azure Stacks using VHD 2020.05.13 #3457

haofan-ms · 2020-06-12T00:39:50Z

Reason for Change:

Update documentation of the Azure Stack page

Issue Fixed:

Requirements:

uses conventional commit messages
includes documentation
adds unit tests
tested upgrade from previous version

Notes:

codecov · 2020-06-12T00:52:16Z

Codecov Report

Merging #3457 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3457   +/-   ##
=======================================
  Coverage   73.16%   73.16%           
=======================================
  Files         147      147           
  Lines       25024    25024           
=======================================
  Hits        18310    18310           
  Misses       5580     5580           
  Partials     1134     1134

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 384aeb1...28c5a4a. Read the comment docs.

jadarsie · 2020-06-12T00:48:21Z

docs/topics/azure-stack.md

@@ -191,7 +195,7 @@ If a `LoadBalancer` service was already created in your cluster, you can find ou

 ### get-versions command

-The output of the `get-versions` command only pertains to Azure and not Azure Stack Hub clouds. The different upgrade paths can be found [here](https://docs.microsoft.com/azure-stack/user/azure-stack-kubernetes-aks-engine-upgrade#steps-to-upgrade-to-a-newer-kubernetes-version).
+The output of the `get-versions` command with `--azure-env AzureStackCloud` shows the Kubernetes version supported on Azure Stack Hub clouds. The upgrade paths can be found [here](https://docs.microsoft.com/azure-stack/user/azure-stack-kubernetes-aks-engine-upgrade#steps-to-upgrade-to-a-newer-kubernetes-version).


This is not true for v0.51.0

jadarsie · 2020-06-12T00:49:54Z

docs/topics/azure-stack.md

@@ -109,6 +110,7 @@ Unless otherwise specified down below, standard [cluster definition](../../docs/
 | Name                            | Required | Description|
 | ------------------------------- | -------- | ---------- |
 | vmsize                          | yes      | Describes a valid [Azure Stack Hub VM size](https://docs.microsoft.com/azure-stack/user/azure-stack-vm-sizes). |
+| OSType                          | no       | Specifies the Operation System type of the agent pool. The default OSType value is `"Linux"`, and supported value is `"Windows"` for Windows OS. |


I would just copy the text from clusterdefinitions.md

Specifies the agent pool's Operating System. Supported values are Windows and Linux. Defaults to Linux

jadarsie · 2020-06-12T00:52:18Z

docs/topics/azure-stack.md

@@ -79,7 +79,8 @@ Unless otherwise specified down below, standard [cluster definition](../../docs/
 | ------------------------------- | -------- | ------------------------------------ |
 | addons                          | no       | A few addons are not supported on Azure Stack Hub. See the [complete list](#unsupported-addons) down below.|
 | kubernetesImageBase             | no       | For AKS Engine versions lower than v0.48.0, this is a required field. It specifies the default image base URL to be used for all Kubernetes-related containers such as hyperkube, cloud-controller-manager, pause, addon-manager, etc. This property should be set to `"mcr.microsoft.com/k8s/azurestack/core/"`. |
-| networkPlugin                   | yes      | Specifies the network plugin implementation for the cluster. Valid values are `"kubenet"` for Kubernetes software networking implementation. |
+| networkPlugin                   | yes      | Specifies the network plugin implementation for the cluster. Valid values are `"kubenet"` for Kubernetes software networking implementation, and `"azure"` for Azure CNI network plugin implementation. |


I would copy the text from clusterdefinition.md

jadarsie · 2020-06-12T00:54:22Z

docs/topics/azure-stack.md

@@ -134,7 +136,9 @@ Each AKS Engine release is validated and tied to a specific version of the AKS B
 | AKS Engine                 | AKS Base Image     | Kubernetes versions | Notes |
 |----------------------------|--------------------|---------------------|-------|
 | [v0.43.1](https://github.com/Azure/aks-engine/releases/tag/v0.43.1)   | [AKS Base Ubuntu 16.04-LTS Image Distro, October 2019 (2019.10.24)](https://github.com/Azure/aks-engine/blob/v0.43.0/releases/vhd-notes/aks-ubuntu-1604/aks-ubuntu-1604-201910_2019.10.24.txt) | 1.15.5, 1.15.4, 1.14.8, 1.14.7 |  |
-| [v0.48.0](https://github.com/Azure/aks-engine/releases/tag/v0.48.0)   | [AKS Base Ubuntu 16.04-LTS Image Distro, March 2020 (2020.03.19)](https://github.com/Azure/aks-engine/blob/v0.48.0/vhd/release-notes/aks-engine-ubuntu-1604/aks-engine-ubuntu-1604-202003_2020.03.19.txt) | 1.15.10, 1.14.7 | [Template](../../examples/azure-stack/kubernetes-azurestack.json) |
+| [v0.48.0](https://github.com/Azure/aks-engine/releases/tag/v0.48.0)   | [AKS Base Ubuntu 16.04-LTS Image Distro, March 2020 (2020.03.19)](https://github.com/Azure/aks-engine/blob/v0.48.0/vhd/release-notes/aks-engine-ubuntu-1604/aks-engine-ubuntu-1604-202003_2020.03.19.txt) | 1.15.10, 1.14.7 |  |
+| [v0.51.0](https://github.com/Azure/aks-engine/releases/tag/v0.51.0)   | [AKS Base Ubuntu 16.04-LTS Image Distro, May 2020 (2020.05.13)](https://github.com/Azure/aks-engine/blob/v0.51.0/vhd/release-notes/aks-engine-ubuntu-1604/aks-engine-ubuntu-1604-202005_2020.05.13.txt), [AKS Base Ubuntu 16.04-LTS Image Distro, May 2020 (2020.05.13)](https://github.com/Azure/aks-engine/blob/v0.51.0/vhd/release-notes/aks-windows/2019-datacenter-core-smalldisk-17763.1217.200513.txt)  | 1.15.11, 1.15.12, 1.16.9, 1.16.10, 1.17.5, 1.17.6 | [Template](../../examples/azure-stack/kubernetes-azurestack.json) |


you have 2 AKS Base Ubuntu 16.04-LTS Image Distro

jadarsie · 2020-06-12T00:55:21Z

examples/azure-stack/kubernetes-azurestack.json

@@ -49,6 +50,15 @@
                "distro": "aks-ubuntu-16.04",
                "availabilityProfile": "AvailabilitySet",
                "AcceleratedNetworkingEnabled": false
+            },
+            {


I would create a new template for windows nodes.

acs-bot · 2020-06-12T18:53:45Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: haofan-ms, jadarsie
To complete the pull request process, please assign ksubrmnn
You can assign the PR to them by writing /assign @ksubrmnn in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

…#3457) * doc: update azure-stack documentation * doc: update aure stack documentation * doc: update aure stack documentation * doc: update aure stack documentation

haofan-ms added 2 commits June 10, 2020 13:05

doc: update azure-stack documentation

1af5cdc

Merge branch 'master' into azs-support-doc

33fbd77

acs-bot added the size/M label Jun 12, 2020

haofan-ms requested a review from jadarsie June 12, 2020 00:44

jadarsie reviewed Jun 12, 2020

View reviewed changes

haofan-ms changed the title ~~doc: Update Azure Stack page~~ doc: supported versions for Azure Stacks using VHD 2020.05.13 Jun 12, 2020

doc: update aure stack documentation

e90dffb

acs-bot added size/S and removed size/M labels Jun 12, 2020

doc: update aure stack documentation

add95e6

mboersma added area/docs azurestack labels Jun 12, 2020

jadarsie changed the title ~~doc: supported versions for Azure Stacks using VHD 2020.05.13~~ docs: supported versions for Azure Stacks using VHD 2020.05.13 Jun 12, 2020

doc: update aure stack documentation

28c5a4a

jadarsie approved these changes Jun 12, 2020

View reviewed changes

jadarsie merged commit 7064ab1 into Azure:master Jun 12, 2020

fmotrifork mentioned this pull request Jun 30, 2020

aks-engine 0.53.0 fishworks/fish-food#818

Merged

haofan-ms deleted the azs-support-doc branch August 11, 2020 05:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

docs: supported versions for Azure Stacks using VHD 2020.05.13 #3457

docs: supported versions for Azure Stacks using VHD 2020.05.13 #3457

haofan-ms commented Jun 12, 2020 •

edited

Loading

codecov bot commented Jun 12, 2020 •

edited

Loading

jadarsie Jun 12, 2020

jadarsie Jun 12, 2020

jadarsie Jun 12, 2020

jadarsie Jun 12, 2020

jadarsie Jun 12, 2020

jadarsie Jun 12, 2020

acs-bot commented Jun 12, 2020

docs: supported versions for Azure Stacks using VHD 2020.05.13 #3457

docs: supported versions for Azure Stacks using VHD 2020.05.13 #3457

Conversation

haofan-ms commented Jun 12, 2020 • edited Loading

codecov bot commented Jun 12, 2020 • edited Loading

Codecov Report

jadarsie Jun 12, 2020

Choose a reason for hiding this comment

jadarsie Jun 12, 2020

Choose a reason for hiding this comment

jadarsie Jun 12, 2020

Choose a reason for hiding this comment

jadarsie Jun 12, 2020

Choose a reason for hiding this comment

jadarsie Jun 12, 2020

Choose a reason for hiding this comment

jadarsie Jun 12, 2020

Choose a reason for hiding this comment

acs-bot commented Jun 12, 2020

haofan-ms commented Jun 12, 2020 •

edited

Loading

codecov bot commented Jun 12, 2020 •

edited

Loading