Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

chore: standardize nodeSelector declarations in addons #3419

Merged
merged 2 commits into from
Jun 5, 2020

Conversation

jackfrancis
Copy link
Member

Reason for Change:

This is a simple PR that changes a few (working) non-standard (as compared to other addons) nodeSelector declarations so that it's 100% consistent.

Issue Fixed:

Requirements:

Notes:

@codecov
Copy link

codecov bot commented Jun 5, 2020

Codecov Report

Merging #3419 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3419   +/-   ##
=======================================
  Coverage   73.20%   73.20%           
=======================================
  Files         147      147           
  Lines       24970    24970           
=======================================
  Hits        18279    18279           
  Misses       5562     5562           
  Partials     1129     1129           
Impacted Files Coverage Δ
pkg/engine/templates_generated.go 54.08% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d758fa...8d27ec2. Read the comment docs.

Copy link
Member

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@acs-bot acs-bot added the lgtm label Jun 5, 2020
@jackfrancis jackfrancis merged commit 9061bae into Azure:master Jun 5, 2020
@jackfrancis jackfrancis deleted the nodeSelector-standardize branch June 5, 2020 22:18
@acs-bot
Copy link

acs-bot commented Jun 5, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis, mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jackfrancis,mboersma]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants