Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

test: expose misconfigured interfaces by downloading large-enough files #3412

Merged
merged 1 commit into from
Jun 5, 2020

Conversation

jadarsie
Copy link
Member

@jadarsie jadarsie commented Jun 4, 2020

Reason for Change:

Adding an E2E test that downloads a file big enough to expose misconfigured network interfaces MTUs.

Issue Fixed:

Related to #3367

Requirements:

@acs-bot acs-bot added the size/S label Jun 4, 2020
@jadarsie jadarsie changed the title test: e2e tests download of larger files test: expose misconfigured interfaces by downloading large-enough files Jun 4, 2020
@codecov
Copy link

codecov bot commented Jun 4, 2020

Codecov Report

Merging #3412 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3412   +/-   ##
=======================================
  Coverage   73.17%   73.17%           
=======================================
  Files         147      147           
  Lines       24923    24923           
=======================================
  Hits        18238    18238           
  Misses       5559     5559           
  Partials     1126     1126           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update efb978a...c609d5c. Read the comment docs.

Copy link
Member

@jackfrancis jackfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@acs-bot
Copy link

acs-bot commented Jun 5, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis, jadarsie

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jadarsie jadarsie merged commit 6d758fa into Azure:master Jun 5, 2020
penggu pushed a commit to penggu/aks-engine that referenced this pull request Oct 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants