-
Notifications
You must be signed in to change notification settings - Fork 519
chore: change MTU only if not Azure CNI on Azure Stack #3367
Conversation
echo " post-up /sbin/ifconfig eth0 mtu 1350" | sudo tee -a /etc/network/interfaces | ||
|
||
ifconfig eth0 mtu 1350 | ||
{{- if not IsAzureCNI}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: unnecessary indentation
(the pattern we've been following thus far is not to indent actual static chars [e.g., the shell script in this case], so you can put the {{
and the echo statements on a common indentation indentation alignment at the beginning of the line)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@jadarsie let me know when you've tested this successfully in an Azure Stack environment, and I'll merge |
Codecov Report
@@ Coverage Diff @@
## master #3367 +/- ##
==========================================
- Coverage 72.16% 70.96% -1.20%
==========================================
Files 147 147
Lines 25419 26873 +1454
==========================================
+ Hits 18343 19070 +727
- Misses 5939 6563 +624
- Partials 1137 1240 +103
Continue to review full report at Codecov.
|
this is good to go |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jackfrancis, jadarsie, mboersma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Reason for Change:
Azure CNI is not using encap, no need to reduce MTU on Azure Stack
Issue Fixed:
Related #1346
Requirements: