Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

fix: ensure /mnt is ext4 #3297

Merged
merged 2 commits into from
May 19, 2020

Conversation

jackfrancis
Copy link
Member

Reason for Change:

This PR follows on from #3273 to ensure that /mnt is mounted as ext4 filesystem type via cloud-init.

Issue Fixed:

Requirements:

Notes:

@anhvoms
Copy link

anhvoms commented May 19, 2020

You might want to add a comment that this is due to cloud-init bug:
https://bugs.launchpad.net/cloud-init/+bug/1879552

The resource disk should get partitioned, formatted, mounted correctly regardless of the presence of datadisks configuration. However, it looks like it only got partitioned and mounted, not formatted correctly

@codecov
Copy link

codecov bot commented May 19, 2020

Codecov Report

Merging #3297 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3297   +/-   ##
=======================================
  Coverage   71.87%   71.87%           
=======================================
  Files         147      147           
  Lines       25529    25529           
=======================================
  Hits        18348    18348           
  Misses       6043     6043           
  Partials     1138     1138           
Impacted Files Coverage Δ
pkg/engine/templates_generated.go 42.19% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b10dbd3...eaf3951. Read the comment docs.

Copy link
Member

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@acs-bot
Copy link

acs-bot commented May 19, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis, mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jackfrancis,mboersma]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jackfrancis jackfrancis merged commit 3f4c780 into Azure:master May 19, 2020
@jackfrancis jackfrancis deleted the cloud-init-ephemeral-mount branch May 19, 2020 22:36
penggu pushed a commit to penggu/aks-engine that referenced this pull request Oct 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants