refactor: consolidate azure-network-policy addon spec #3283
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3283 +/- ##
==========================================
+ Coverage 71.64% 71.75% +0.10%
==========================================
Files 147 147
Lines 25583 25550 -33
==========================================
+ Hits 18330 18333 +3
+ Misses 6115 6079 -36
Partials 1138 1138
Continue to review full report at Codecov.
|
|
Just to be pedantic we aren't renaming the addon here, just the source yaml file that we use to maintain it. |
fix: add a missing dot
mboersma
force-pushed
the
consolidate-azure-npm-spec
branch
from
5a4f7a5 to
f670965
Compare
| annotations: | ||
| scheduler.alpha.kubernetes.io/critical-pod: '' | ||
| {{- if IsKubernetesVersionGe "1.17.0"}} | ||
| cluster-autoscaler.kubernetes.io/daemonset-pod: "true" | ||
| {{- end}} |
There was a problem hiding this comment.
We need the newlines here in both negative cases, so should be {{end}}
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jackfrancis, mboersma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Reason for Change:
Eases maintenance of the (newly renamed) azure-network-policy addon by consolidating manifests into a single YAML file that uses Go templating.
Issue Fixed:
Addresses #3188.
Requirements:
Notes: