Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

chore: remove defunct build-windows-k8s.sh script #3248

Merged
merged 1 commit into from
May 14, 2020

Conversation

mboersma
Copy link
Member

Reason for Change:
Removes make build-azs-windows-k8s and its supporting script, because creating this archive is now handled by the upstream Azure Pipelines build of Kubernetes.

Issue Fixed:
Closes #2266

Requirements:

Notes:

Copy link
Member

@jackfrancis jackfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@jackfrancis
Copy link
Member

@jadarsie for final approval

@codecov
Copy link

codecov bot commented May 13, 2020

Codecov Report

Merging #3248 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3248   +/-   ##
=======================================
  Coverage   71.56%   71.56%           
=======================================
  Files         147      147           
  Lines       25637    25637           
=======================================
  Hits        18346    18346           
  Misses       6150     6150           
  Partials     1141     1141           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b626696...dd77ae8. Read the comment docs.

@jadarsie
Copy link
Member

/lgtm

@acs-bot
Copy link

acs-bot commented May 14, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis, jadarsie, mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jackfrancis,mboersma]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mboersma mboersma merged commit ba98cde into Azure:master May 14, 2020
@mboersma mboersma deleted the fist-bump-to-patrick-lang branch May 14, 2020 19:05
penggu pushed a commit to penggu/aks-engine that referenced this pull request Oct 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make build-windows-k8s fails after go mod changes
4 participants