Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

ci: ensure sku title/summary/longsummary is unique when creating new … #3239

Merged
merged 1 commit into from
May 12, 2020

Conversation

marosset
Copy link
Contributor

@marosset marosset commented May 12, 2020

…marketplace skus

Reason for Change:

SKU names must be unique and since we are now creating Windows VHDS for both docker and containerd we need a way to differentiate the SKU names.

Issue Fixed:

Requirements:

Notes:

@marosset
Copy link
Contributor Author

/cc @CecileRobertMichon

@acs-bot
Copy link

acs-bot commented May 12, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: marosset

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented May 12, 2020

Codecov Report

Merging #3239 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3239   +/-   ##
=======================================
  Coverage   71.45%   71.45%           
=======================================
  Files         147      147           
  Lines       25671    25671           
=======================================
  Hits        18342    18342           
  Misses       6187     6187           
  Partials     1142     1142           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 563b082...3331751. Read the comment docs.

@marosset
Copy link
Contributor Author

I'm going to merge this to speed up the release of Windows VHDs

@marosset marosset merged commit 28babdc into Azure:master May 12, 2020
@marosset marosset deleted the win-vhd-publishing-new-sku-updates branch May 13, 2020 23:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants