Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

fix: aad-pod-identity taints foo works in k8s < 1.16 #3199

Merged
merged 1 commit into from
May 6, 2020

Conversation

jackfrancis
Copy link
Member

Reason for Change:

This PR fixes two errata surfaced in 1.14 and 1.15 tests that include aad-pod-identity.

  1. move the ensureTaints CSE func out of the "is k8s version >= 1.16?" block
  2. use the documented kubectl taint nodes syntax (remove the =true expression after the taint key, which I guess works in 1.16+)

Issue Fixed:

Requirements:

Notes:

@jackfrancis jackfrancis force-pushed the fix-ensureTaints-cse branch from d9c1e57 to d108534 Compare May 5, 2020 22:59
@codecov
Copy link

codecov bot commented May 5, 2020

Codecov Report

Merging #3199 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3199   +/-   ##
=======================================
  Coverage   71.23%   71.23%           
=======================================
  Files         147      147           
  Lines       25735    25735           
=======================================
  Hits        18332    18332           
  Misses       6258     6258           
  Partials     1145     1145           
Impacted Files Coverage Δ
pkg/engine/templates_generated.go 38.67% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe31ff6...d108534. Read the comment docs.

Copy link
Member

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@acs-bot
Copy link

acs-bot commented May 6, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis, mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jackfrancis,mboersma]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jackfrancis jackfrancis merged commit a43a9c4 into Azure:master May 6, 2020
@jackfrancis jackfrancis deleted the fix-ensureTaints-cse branch May 6, 2020 18:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants