-
Notifications
You must be signed in to change notification settings - Fork 519
feat: add support for Kubernetes 1.19.0-alpha.3 #3197
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3197 +/- ##
==========================================
- Coverage 71.15% 68.97% -2.19%
==========================================
Files 147 147
Lines 25768 27725 +1957
==========================================
+ Hits 18336 19124 +788
- Misses 6286 7366 +1080
- Partials 1146 1235 +89
Continue to review full report at Codecov.
|
/hold There's a temporary testing commit here that should be discarded. |
b41d362
to
178f2d4
Compare
The 1.19 PR run passed, so I stripped off the test commit and this should be ready for review. |
/hold cancel |
I honestly don't know where CodeCov is coming from these days. This is a one-line change to one .go file. We need to rationalize our coverage numbers somehow, because I haven't found its report to be useful for months now. Edit: see #3203. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jackfrancis, mboersma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Reason for Change:
See https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG/CHANGELOG-1.19.md#changelog-since-v1190-alpha2
Issue Fixed:
Requirements:
Notes:
There were several APIs deprecated with this release, but I think we should defer updating them. See #3196.