Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

update deprecated APIs in 1.19 manifests #3196

Closed
mboersma opened this issue May 5, 2020 · 1 comment
Closed

update deprecated APIs in 1.19 manifests #3196

mboersma opened this issue May 5, 2020 · 1 comment
Labels
enhancement New feature or request stale

Comments

@mboersma
Copy link
Member

mboersma commented May 5, 2020

Describe the request
Several Kubernetes APIs were deprecated in the 1.19.0-alpha.3 release:
https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG/CHANGELOG-1.19.md#deprecation

Specifically:

Deprecated 1.19+
apiextensions.k8s.io/v1beta1 apiextensions.k8s.io/v1
apiregistration.k8s.io/v1beta1 apiregistration.k8s.io/v1
authentication.k8s.io/v1beta1 authentication.k8s.io/v1
autoscaling/v2beta1 autoscaling/v2beta2
coordination.k8s.io/v1beta1 coordination.k8s.io/v1
storage.k8s.io/v1beta1 storage.k8s.io/v1

I began making these changes to the 1.19 manifests in the 1.19.0-alpha.3 PR (#3197) but quickly realized:

Explain why AKS Engine needs it

Describe the solution you'd like
Adding some go template code to the unified manifests after #3188 is completed, to change these API versions depending on Kubernetes version in a self-documenting way:

{{- if IsKubernetesVersionGe "1.19.0-alpha.3"}}
apiVersion: apiextensions.k8s.io/v1
{{else}}
apiVersion: apiextensions.k8s.io/v1beta1
{{- end}}

Describe alternatives you've considered

Additional context

@mboersma mboersma added the enhancement New feature or request label May 5, 2020
@stale
Copy link

stale bot commented Jul 4, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jul 4, 2020
@stale stale bot closed this as completed Jul 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request stale
Projects
None yet
Development

No branches or pull requests

1 participant