Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

chore: Updating Azure NPM to v1.1.2 #3178

Merged
merged 2 commits into from
May 11, 2020
Merged

Conversation

jaer-tsun
Copy link
Contributor

@jaer-tsun jaer-tsun commented May 1, 2020

Reason for Change:
Contains the latest changes in the v1.1.2 Azure NPM release
https://github.com/Azure/azure-container-networking/releases/tag/v1.1.2

Issue Fixed:

Requirements:

Notes:

@acs-bot acs-bot added the size/M label May 1, 2020
@jaer-tsun
Copy link
Contributor Author

/assign @ritazh

@mboersma
Copy link
Member

mboersma commented May 2, 2020

/azp run pr-e2e

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@codecov
Copy link

codecov bot commented May 2, 2020

Codecov Report

Merging #3178 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3178   +/-   ##
=======================================
  Coverage   71.37%   71.37%           
=======================================
  Files         147      147           
  Lines       25687    25687           
=======================================
  Hits        18335    18335           
  Misses       6207     6207           
  Partials     1145     1145           
Impacted Files Coverage Δ
pkg/api/k8s_versions.go 100.00% <ø> (ø)
pkg/engine/templates_generated.go 39.62% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41d8f69...335cc07. Read the comment docs.

@jackfrancis
Copy link
Member

Tested this change and got a consistent error:

Azure Container Cluster using the Kubernetes Orchestrator
 �[90m/aks-engine/test/e2e/kubernetes/kubernetes_test.go:175�[0m
   with NetworkPolicy enabled
   �[90m/aks-engine/test/e2e/kubernetes/kubernetes_test.go:1582�[0m
     �[91m�[1mshould apply various network policies and enforce access to nginx pod [It]�[0m
     �[90m/aks-engine/test/e2e/kubernetes/kubernetes_test.go:1583�[0m
 
     �[91mExpected error:
         <*errors.fundamental | 0xc00031e080>: {
             msg: "Timeout exceeded (3m0s) while waiting for PodList to check outbound internet connection",
             stack: [0x94239e, 0x9575cc, 0x98e119, 0x8cbe03, 0x8cba6f, 0x8caf14, 0x8d1c88, 0x8d1442, 0x8d727f, 0x8d6da0, 0x8d65e7, 0x8d8b5b, 0x8db2a7, 0x8dafed, 0x9670c7, 0x50afdc, 0x469281],
         }
         Timeout exceeded (3m0s) while waiting for PodList to check outbound internet connection
     not to have occurred�[0m
 
     /aks-engine/test/e2e/kubernetes/networkpolicy/networkpolicy.go:75
 �[90m------------------------------�[0m
 �[36mS�[0m�[36mS�[0m�[36mS�[0m�[36mS�[0m�[36mS�[0m�[36mS�[0m�[36mS�[0m�[36mS�[0m

It looks like it's failing this test:

https://github.com/Azure/aks-engine/blob/master/test/e2e/kubernetes/kubernetes_test.go#L1720

@jaer-tsun
Copy link
Contributor Author

@jackfrancis Do you know where I can find that pod spec? From the iptable entries it's working as expected.

@jackfrancis
Copy link
Member

It's this image: library/nginx:latest. This doc might help you to repro the E2E tests locally:

https://github.com/Azure/aks-engine/blob/master/docs/community/running-tests.md

@jaer-tsun jaer-tsun changed the title chore: Updating Azure NPM to v1.1.1 chore: Updating Azure NPM to v1.1.2 May 8, 2020
@mboersma
Copy link
Member

/azp run pr-e2e

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@jackfrancis jackfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@acs-bot acs-bot added the lgtm label May 11, 2020
@jackfrancis jackfrancis merged commit 0c0d7ac into Azure:master May 11, 2020
@acs-bot
Copy link

acs-bot commented May 11, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis, jaer-tsun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jaer-tsun jaer-tsun deleted the updateNPM branch May 11, 2020 22:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants