Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

feat: add warning message for empty Location string #3174

Merged
merged 2 commits into from
May 1, 2020

Conversation

jackfrancis
Copy link
Member

@jackfrancis jackfrancis commented May 1, 2020

Reason for Change:

This PR introduces a stdout warning message when AKS Engine template generation observes an empty "location" value in the input api model. We want to tell folks pro-actively that AKS Engine will treat that empty string significantly, and that the resultant ARM templates will work exclusively for public cloud regions.

Issue Fixed:

Addresses part of #3170

Requirements:

Notes:

@jackfrancis
Copy link
Member Author

@gball14 FYI

@jackfrancis
Copy link
Member Author

@gurudatttest FYI

@codecov
Copy link

codecov bot commented May 1, 2020

Codecov Report

Merging #3174 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3174   +/-   ##
=======================================
  Coverage   71.23%   71.23%           
=======================================
  Files         147      147           
  Lines       25745    25747    +2     
=======================================
+ Hits        18340    18342    +2     
  Misses       6268     6268           
  Partials     1137     1137           
Impacted Files Coverage Δ
pkg/api/vlabs/validate.go 80.19% <100.00%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29dd816...5992367. Read the comment docs.

Copy link
Member

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@acs-bot
Copy link

acs-bot commented May 1, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis, mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jackfrancis,mboersma]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jackfrancis jackfrancis merged commit 662c433 into Azure:master May 1, 2020
@jackfrancis jackfrancis deleted the location-warning branch May 1, 2020 20:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants