Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

feat: disable dashboard addon by default #3093

Merged
merged 1 commit into from
Apr 18, 2020

Conversation

mboersma
Copy link
Member

@mboersma mboersma commented Apr 17, 2020

Reason for Change:
The kubernetes-dashboard implementation is stale and not considered compatible with current versions of Kubernetes, so this change disables it by default. It can still be turned on if desired by enabling it explicitly in a cluster config (apimodel).

Issue Fixed:
Fixes #3021

Requirements:

Notes:
Users can try out the new pre-release versions by following the current documentation for Kubernetes Dashboard.

@codecov
Copy link

codecov bot commented Apr 17, 2020

Codecov Report

Merging #3093 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3093      +/-   ##
==========================================
- Coverage   70.64%   70.61%   -0.03%     
==========================================
  Files         147      147              
  Lines       25430    25430              
==========================================
- Hits        17965    17958       -7     
- Misses       6342     6350       +8     
+ Partials     1123     1122       -1     
Impacted Files Coverage Δ
pkg/engine/templates_generated.go 35.21% <0.00%> (-0.31%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95b7254...b05467b. Read the comment docs.

Copy link
Member

@jackfrancis jackfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@mboersma mboersma merged commit 6bf9df3 into Azure:master Apr 18, 2020
@mboersma mboersma deleted the disable-dashboard branch April 18, 2020 03:44
alexeldeib pushed a commit to alexeldeib/aks-engine that referenced this pull request Apr 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable dashboard addon by default
2 participants