This repository has been archived by the owner on Oct 24, 2023. It is now read-only.
feat: deprecate CoreOS support #2945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @alexeldeib 🍷 ⚰️ |
jackfrancis
changed the title
Codecov Report
@@ Coverage Diff @@
## master #2945 +/- ##
==========================================
+ Coverage 72.57% 72.57% +<.01%
==========================================
Files 141 141
Lines 25934 25886 -48
==========================================
- Hits 18821 18787 -34
+ Misses 6014 6005 -9
+ Partials 1099 1094 -5 |
mboersma
reviewed
Mar 24, 2020
| @@ -29,7 +29,7 @@ const ( | |||
| Ubuntu1804 Distro = "ubuntu-18.04" | |||
| Ubuntu1804Gen2 Distro = "ubuntu-18.04-gen2" | |||
| RHEL Distro = "rhel" | |||
| CoreOS Distro = "coreos" | |||
| CoreOS Distro = "coreos" // deprecated | |||
There was a problem hiding this comment.
Does this constant remain as a notice of its deprecation, or because code still refers to it somewhere?
mboersma
reviewed
Mar 25, 2020
pkg/api/vlabs/validate_test.go
Outdated
| @@ -3500,6 +3500,23 @@ func TestValidateProperties_OrchestratorSpecificProperties(t *testing.T) { | |||
| t.Errorf("expected error with message : %s, but got %s", expectedMsg, err.Error()) | |||
| } | |||
| }) | |||
|
|
|||
| t.Run("Should not support os type other than linux for single stack ipv6 and dual stack feature", func(t *testing.T) { | |||
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jackfrancis, mboersma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
jackfrancis
pushed a commit
to jackfrancis/aks-engine
that referenced
this pull request
Jun 1, 2020
This reverts commit b1284c7.
jackfrancis
pushed a commit
to jackfrancis/aks-engine
that referenced
this pull request
Jun 4, 2020
This reverts commit b1284c7.
jackfrancis
pushed a commit
to jackfrancis/aks-engine
that referenced
this pull request
Jun 5, 2020
This reverts commit b1284c7.
jackfrancis
pushed a commit
to jackfrancis/aks-engine
that referenced
this pull request
Jun 5, 2020
This reverts commit b1284c7.
jackfrancis
pushed a commit
to jackfrancis/aks-engine
that referenced
this pull request
Jun 10, 2020
This reverts commit b1284c7.
jackfrancis
pushed a commit
to jackfrancis/aks-engine
that referenced
this pull request
Jun 10, 2020
This reverts commit b1284c7.
jackfrancis
pushed a commit
to jackfrancis/aks-engine
that referenced
this pull request
Jun 10, 2020
This reverts commit b1284c7.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
This PR removes aks-engine support for coreos. Any existing clusters will no longer be maintainable via future versions of aks-engine once this PR merges.
This was always an experimental configuration, and now that CoreOS has officially ridden off into the sunset, now seems like a good time to remove some of the maintenance surface area of the codebase.
See:
https://coreos.com/os/eol/
Issue Fixed:
Requirements:
Notes: