Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

refactor: Parse sgx dcap version file, enable checksum #2942

Merged

Conversation

Francis-Liu
Copy link
Contributor

Signed-off-by: Francis Liu [email protected]

Reason for Change:

  1. Refactor code to parse dcap version based on version.xml.
  2. Enable checksum validation

Requirements:

Notes:

@acs-bot acs-bot added the size/S label Mar 20, 2020
@Francis-Liu Francis-Liu force-pushed the Francis-Liu/parse-sgx-version-xml branch from 9c5aa2e to 9d21383 Compare March 20, 2020 21:06
@jackfrancis
Copy link
Member

/azp run pr-e2e

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@codecov
Copy link

codecov bot commented Mar 20, 2020

Codecov Report

Merging #2942 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2942   +/-   ##
=======================================
  Coverage   72.57%   72.57%           
=======================================
  Files         141      141           
  Lines       25934    25934           
=======================================
  Hits        18821    18821           
  Misses       6014     6014           
  Partials     1099     1099

Copy link
Member

@jackfrancis jackfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@acs-bot
Copy link

acs-bot commented Mar 20, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Francis-Liu, jackfrancis, paulcallen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jackfrancis jackfrancis merged commit 0b43044 into Azure:master Mar 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants