fix: check network to k8s api for vmss #2938
Conversation
bowang-666
changed the title
|
/azp run pr-e2e |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Codecov Report
@@ Coverage Diff @@
## master #2938 +/- ##
==========================================
+ Coverage 72.55% 72.57% +0.01%
==========================================
Files 141 141
Lines 25928 25934 +6
==========================================
+ Hits 18813 18821 +8
+ Misses 6016 6014 -2
Partials 1099 1099
Continue to review full report at Codecov.
|
|
/azp run pr-e2e |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@xuto2 @yangl900 strictly speaking, we could put this k8s apiserver check at the end of CSE instead of the beginning. In other words, there is nothing in the CSE code (let me know if I'm wrong) that won't work until the apiserver is responsive. And so by delaying the start of CSE until we get that response, we may end up delaying the overall cluster operation by 15-20 seconds or so (the time it takes to run CSE in a VHD-backed context). |
|
/lgtm |
|
@jackfrancis AKS does many things after creating ccp and before adding nodes, including setup dns for api server, deploy non-VMSS/non-VMAS resources in ARM, which take a while. So for most case, by the time of cse execution, our api server is already up and this check is a precondition check that we want to fail earlier if node cannot even talk to the api server. I'm not sure about AKS-Engine scenarios though. Is it possible master node is not up when agent node is running cse when an AKS-Engine cluster is created? |
|
Actually we discussed and it makes more sense to put it in end, I will make the change. |
|
/azp run pr-e2e |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run pr-e2e |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run pr-e2e |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bowang-666, jackfrancis, xuto2 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* fix: check network from node to k8s api server in CSE (#2919) * fix: check network to k8s api for vmss (#2938) * fix: check dns status before connection (#3002) Co-authored-by: Bo Wang <[email protected]> Co-authored-by: Bo Wang <[email protected]>
Reason for Change:
We need to also check network connection to k8s api for vmss. Preivous change: #2919
Issue Fixed:
Requirements:
Notes: