Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

test: add egress tests which target pod and namespace. #2925

Merged
merged 3 commits into from
Mar 24, 2020
Merged

test: add egress tests which target pod and namespace. #2925

merged 3 commits into from
Mar 24, 2020

Conversation

csfmomo
Copy link
Contributor

@csfmomo csfmomo commented Mar 18, 2020

Reason for Change:
Add network policy tests which target pod and namespace selector specifically.

Requirements:

Notes:

@acs-bot acs-bot added the size/M label Mar 18, 2020
@jackfrancis
Copy link
Member

/azp run pr-e2e

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@codecov
Copy link

codecov bot commented Mar 18, 2020

Codecov Report

Merging #2925 into master will increase coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2925      +/-   ##
==========================================
+ Coverage   72.49%   72.57%   +0.07%     
==========================================
  Files         141      141              
  Lines       25847    25934      +87     
==========================================
+ Hits        18739    18821      +82     
+ Misses       6021     6014       -7     
- Partials     1087     1099      +12     
Impacted Files Coverage Δ
pkg/engine/virtualmachinescalesets.go 80.58% <0.00%> (-0.85%) ⬇️
pkg/api/vlabs/validate.go 78.20% <0.00%> (-0.62%) ⬇️
pkg/engine/virtualmachines.go 80.66% <0.00%> (-0.45%) ⬇️
pkg/api/types.go 95.21% <0.00%> (-0.43%) ⬇️
pkg/api/common/const.go 0.00% <0.00%> (ø)
pkg/engine/template_generator.go 80.96% <0.00%> (+0.02%) ⬆️
pkg/api/convertertoapi.go 93.61% <0.00%> (+0.04%) ⬆️
pkg/api/converterfromapi.go 93.80% <0.00%> (+0.04%) ⬆️
pkg/engine/armvariables.go 87.28% <0.00%> (+0.36%) ⬆️
pkg/api/vlabs/types.go 74.47% <0.00%> (+0.54%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 60ef6be...635b352. Read the comment docs.

@acs-bot acs-bot added size/L and removed size/M labels Mar 19, 2020
@jackfrancis
Copy link
Member

/azp run pr-e2e

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@acs-bot acs-bot added size/M and removed size/L labels Mar 20, 2020
@jackfrancis
Copy link
Member

/azp run pr-e2e

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@jackfrancis jackfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@acs-bot acs-bot added the lgtm label Mar 24, 2020
@jackfrancis jackfrancis merged commit b6870bb into Azure:master Mar 24, 2020
@acs-bot
Copy link

acs-bot commented Mar 24, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csfmomo, jackfrancis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants