-
Notifications
You must be signed in to change notification settings - Fork 519
fix: scale cannot find VM index for the VMAS+VHD+Linux case #2906
Conversation
/lgtm |
Codecov Report
@@ Coverage Diff @@
## master #2906 +/- ##
=========================================
+ Coverage 72.5% 72.5% +<.01%
=========================================
Files 141 141
Lines 25744 25743 -1
=========================================
Hits 18666 18666
+ Misses 5998 5997 -1
Partials 1080 1080 |
@jadarsie Let's ensure we protect any fixes to VMAS + scale by adding (under the env config object) |
Lets add a windows node pool to the ^^^ config |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jackfrancis, jadarsie, marosset The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Reason for Change:
Scaling fails if the target pool is a VMAS pool of VHD-based linux nodes.
VM
osPublisher
is not enought to distinguish between Linux and Windows.Notes: