This repository has been archived by the owner on Oct 24, 2023. It is now read-only.
chore: updating windows VHD to include 3B patches + march k8s packages #2902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackfrancis
reviewed
Mar 13, 2020
| "https://kubernetesartifacts.azureedge.net/kubernetes/v1.17.2/windowszip/v1.17.2-1int.zip", | ||
| "https://kubernetesartifacts.azureedge.net/kubernetes/v1.17.3/windowszip/v1.17.3-1int.zip", | ||
| "https://kubernetesartifacts.azureedge.net/kubernetes/v1.18.0-beta.1/windowszip/v1.18.0-beta.1-1int.zip" | ||
| "https://kubernetesartifacts.azureedge.net/kubernetes/v1.17.4/windowszip/v1.17.4-1int.zip", |
There was a problem hiding this comment.
Are we intentionally leaving 3 versions in here?
There was a problem hiding this comment.
3 patch releases per minor version, I should say
There was a problem hiding this comment.
I think not keeping older versions is negatively impacting AKS cluster creation times.
There was a problem hiding this comment.
I don't have any data to back that up tho.
There was a problem hiding this comment.
Being conservative is fine w/ me
Codecov Report
@@ Coverage Diff @@
## master #2902 +/- ##
=========================================
+ Coverage 72.48% 72.5% +0.02%
=========================================
Files 140 141 +1
Lines 25694 25744 +50
=========================================
+ Hits 18624 18666 +42
- Misses 5994 5998 +4
- Partials 1076 1080 +4 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Issue Fixed:
Requirements:
Notes: