Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

fix: add validation for new AKS engine Windows Version #2896

Merged
merged 2 commits into from
Mar 17, 2020
Merged

fix: add validation for new AKS engine Windows Version #2896

merged 2 commits into from
Mar 17, 2020

Conversation

deaborch
Copy link
Contributor

Reason for Change:

I updated the image validation code flow to take into account the new windows vhd details

Issue Fixed:

Requirements:

Notes:

@deaborch deaborch requested review from devigned and jadarsie March 13, 2020 04:57
@codecov
Copy link

codecov bot commented Mar 13, 2020

Codecov Report

Merging #2896 into master will increase coverage by <.01%.
The diff coverage is 78.57%.

@@            Coverage Diff            @@
##           master   #2896      +/-   ##
=========================================
+ Coverage    72.5%   72.5%   +<.01%     
=========================================
  Files         141     141              
  Lines       25744   25757      +13     
=========================================
+ Hits        18666   18676      +10     
- Misses       5998    5999       +1     
- Partials     1080    1082       +2

@deaborch deaborch requested a review from jackfrancis March 13, 2020 19:42
@jadarsie jadarsie changed the title Fix: Add validation for new AKS engine Windows Version fix: add validation for new AKS engine Windows Version Mar 16, 2020
@acs-bot acs-bot added the size/M label Mar 16, 2020
@jadarsie
Copy link
Member

/lgtm

@mboersma
Copy link
Member

/approve

@acs-bot
Copy link

acs-bot commented Mar 17, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deaborch, jadarsie, mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@acs-bot acs-bot merged commit e54a2b7 into Azure:master Mar 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants