This repository has been archived by the owner on Oct 24, 2023. It is now read-only.
feat: collect Windows CSE logs during log collection #2858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackfrancis
reviewed
Mar 6, 2020
| @@ -40,6 +40,7 @@ Invoke-WebRequest -UseBasicParsing https://raw.githubusercontent.com/Microsoft/S | |||
| & 'c:\k\debug\collectlogs.ps1' | write-Host | |||
| $netLogs = Get-ChildItem (Get-ChildItem -Path c:\k\debug -Directory | Sort-Object LastWriteTime -Descending | Select-Object -First 1).FullName | Select-Object -ExpandProperty FullName | |||
| $paths += $netLogs | |||
| $paths += "c:\AzureData\CustomDataSetupScript.log" | |||
There was a problem hiding this comment.
nit: in the future let's process this and windows cse scripts via go templating so we can refer to this string programmatically (as a common reference that cse + log collection script can both use)
There was a problem hiding this comment.
We intentionally don't want this script to be processed via go templating.
We want users to be able to curl this and run it if it isn't already on the node.
Codecov Report
@@ Coverage Diff @@
## master #2858 +/- ##
=======================================
Coverage 72.47% 72.47%
=======================================
Files 140 140
Lines 25612 25612
=======================================
Hits 18562 18562
Misses 5981 5981
Partials 1069 1069 Continue to review full report at Codecov.
|
AbelHu
pushed a commit
to AbelHu/aks-engine
that referenced
this pull request
Apr 20, 2020
andyliuliming
pushed a commit
that referenced
this pull request
Apr 21, 2020
* chore: adding azure-cni v1.0.33 artifacts to VHDs (#2790) * chore: update Azure CNI to v1.0.33 (#2825) * feat: collect Windows CSE logs during log collection (#2858) * fix: Windows no outbound fixes (#2883) * fix: fixing nssm logging in windows CSE (#2890) * fix: Get WindowsVersion from registry instead of calling Get-ComputerInfo (#2954) * feat: Updating AKS to use April 2020 Windows VHDs by default (#3060) Co-authored-by: Mark Rossetti <[email protected]> Co-authored-by: Jaeryn <[email protected]> Co-authored-by: Kalya Subramanian <[email protected]>
4 tasks
AbelHu
added a commit
to AbelHu/aks-engine
that referenced
this pull request
Apr 22, 2020
* chore: adding azure-cni v1.0.33 artifacts to VHDs (Azure#2790) * chore: update Azure CNI to v1.0.33 (Azure#2825) * feat: collect Windows CSE logs during log collection (Azure#2858) * fix: Windows no outbound fixes (Azure#2883) * fix: fixing nssm logging in windows CSE (Azure#2890) * fix: Get WindowsVersion from registry instead of calling Get-ComputerInfo (Azure#2954) * feat: Updating AKS to use April 2020 Windows VHDs by default (Azure#3060) Co-authored-by: Mark Rossetti <[email protected]> Co-authored-by: Jaeryn <[email protected]> Co-authored-by: Kalya Subramanian <[email protected]>
4 tasks
xuto2
pushed a commit
that referenced
this pull request
Apr 23, 2020
* Upgrade Windows VHD image to April release (#3111) * chore: adding azure-cni v1.0.33 artifacts to VHDs (#2790) * chore: update Azure CNI to v1.0.33 (#2825) * feat: collect Windows CSE logs during log collection (#2858) * fix: Windows no outbound fixes (#2883) * fix: fixing nssm logging in windows CSE (#2890) * fix: Get WindowsVersion from registry instead of calling Get-ComputerInfo (#2954) * feat: Updating AKS to use April 2020 Windows VHDs by default (#3060) Co-authored-by: Mark Rossetti <[email protected]> Co-authored-by: Jaeryn <[email protected]> Co-authored-by: Kalya Subramanian <[email protected]> * feat: adding kubelet and csi-proxy-server as windows defender excluded processes (#2967) (#3118) Co-authored-by: Mark Rossetti <[email protected]> Co-authored-by: Mark Rossetti <[email protected]> Co-authored-by: Jaeryn <[email protected]> Co-authored-by: Kalya Subramanian <[email protected]>
AbelHu
pushed a commit
to AbelHu/aks-engine
that referenced
this pull request
Apr 23, 2020
andyliuliming
pushed a commit
that referenced
this pull request
Apr 23, 2020
* feat: Adding WindowsNodeReset.ps1 script to reset/cleanup state for nodes (#2457) * Adding WindowsNodeReset.ps1 script to reset/cleanup state for windox^C nodes * fix linting errors * fixing comments per CR feedback * chore: adding azure-cni v1.0.33 artifacts to VHDs (#2790) * chore: update Azure CNI to v1.0.33 (#2825) * feat: collect Windows CSE logs during log collection (#2858) * fix: Windows no outbound fixes (#2883) * fix: fixing nssm logging in windows CSE (#2890) * fix: Get WindowsVersion from registry instead of calling Get-ComputerInfo (#2954) * feat: adding kubelet and csi-proxy-server as windows defender excluded processes (#2967) * feat: Updating AKS to use April 2020 Windows VHDs by default (#3060) * feat: Updating Windows VHDs with 4B patches (#3115) Co-authored-by: Mark Rossetti <[email protected]> Co-authored-by: Jaeryn <[email protected]> Co-authored-by: Kalya Subramanian <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Issue Fixed:
Requirements:
Notes: