Add template/options for using Shared Image Gallery #2687
Conversation
|
💖 Thanks for opening your first pull request! 💖 We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should make sure your first commit and PR title start with a semantic prefix. Examples of commit messages with semantic prefixes: - |
| @@ -41,7 +41,11 @@ installEtcd() { | |||
| docker run --rm --entrypoint cat ${CONTAINER_IMAGE} /usr/local/bin/etcd > "$path/etcd" | |||
| docker run --rm --entrypoint cat ${CONTAINER_IMAGE} /usr/local/bin/etcdctl > "$path/etcdctl" | |||
| else | |||
| img unpack -o "$path" ${CONTAINER_IMAGE} | |||
| # img unpack requires a non-existent dirctory | |||
| tmpdir=/root/etcd${RANDOM} | |||
There was a problem hiding this comment.
So that's what I tried, but note the comment above - img unpack requires a non-existent directory. Once mktemp creates the directory, img will refuse to unpack to that path. Believe me I tried :) As I said earlier, I honestly don't know how this ever worked, and I couldn't find an img option to unpack to an existing directory.
|
/azp run pr-e2e |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run pr-e2e |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Codecov Report
@@ Coverage Diff @@
## master #2687 +/- ##
=======================================
Coverage 72.33% 72.33%
=======================================
Files 137 137
Lines 25317 25317
=======================================
Hits 18314 18314
Misses 5947 5947
Partials 1056 1056 |
Add config options for arbitrary Debian-based images
Remove unneeded kernel modules Modify/remove comments
Abstract package requirements in installDeps
|
/azp run pr-e2e |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jackfrancis, mbearup The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Congrats on merging your first pull request! 🎉🎉🎉 |
Add config options for arbitrary Debian-based images
Reason for Change:
Adds a template and fixes for using images from shared image gallery.
Issue Fixed:
None
Requirements:
N/A
Notes: