Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

feat: add support for Kubernetes 1.18.0-alpha.3 #2682

Merged
merged 2 commits into from
Feb 19, 2020

Conversation

mboersma
Copy link
Member

@mboersma mboersma commented Feb 4, 2020

Reason for Change:
See https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG/CHANGELOG-1.18.md#changelog-since-v1180-alpha2

Issue Fixed:

Requirements:

  • Windows artifacts uploaded to acsmirror blob store
  • uses conventional commit messages
  • includes documentation
  • adds unit tests
  • tested upgrade from previous version

Notes:

@acs-bot acs-bot added the size/XS label Feb 4, 2020
@mboersma
Copy link
Member Author

mboersma commented Feb 4, 2020

/hold

Still need to mirror Windows support archive file.

@codecov
Copy link

codecov bot commented Feb 4, 2020

Codecov Report

Merging #2682 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2682   +/-   ##
=======================================
  Coverage   72.34%   72.34%           
=======================================
  Files         137      137           
  Lines       25344    25344           
=======================================
  Hits        18334    18334           
  Misses       5953     5953           
  Partials     1057     1057

@mboersma
Copy link
Member Author

mboersma commented Feb 5, 2020

/hold cancel

@jackfrancis
Copy link
Member

Looks we may have another I ❤️ tests story, consistent failure on kubectl port-forward.

@mboersma
Copy link
Member Author

The failure arises from ImagePullBackoff for the nginx deployment, but the specific error is new to me:

% k describe pod portforwardlinux-2726 
Name:         portforwardlinux-2726
Namespace:    default
Priority:     0
Node:         1269k8s01000000/10.239.16.4
Start Time:   Wed, 12 Feb 2020 09:28:58 -0700
Labels:       run=portforwardlinux-2726
Annotations:  kubernetes.io/psp: privileged
Status:       Pending
IP:           10.239.16.18
IPs:
  IP:  10.239.16.18
Containers:
  portforwardlinux-2726:
    Container ID:   
    Image:          library/nginx:latest
    Image ID:       
    Port:           <none>
    Host Port:      <none>
    State:          Waiting
      Reason:       ImagePullBackOff
    Ready:          False
    Restart Count:  0
    Environment:    <none>
    Mounts:
      /var/run/secrets/kubernetes.io/serviceaccount from default-token-2fp2j (ro)
Conditions:
  Type              Status
  Initialized       True 
  Ready             False 
  ContainersReady   False 
  PodScheduled      True 
Volumes:
  default-token-2fp2j:
    Type:        Secret (a volume populated by a Secret)
    SecretName:  default-token-2fp2j
    Optional:    false
QoS Class:       BestEffort
Node-Selectors:  <none>
Tolerations:     node.kubernetes.io/not-ready:NoExecute for 300s
                 node.kubernetes.io/unreachable:NoExecute for 300s
Events:
  Type     Reason          Age                  From                      Message
  ----     ------          ----                 ----                      -------
  Normal   Scheduled       31m                  default-scheduler         Successfully assigned default/portforwardlinux-2726 to 1269k8s01000000
  Normal   SandboxChanged  30m (x4 over 31m)    kubelet, 1269k8s01000000  Pod sandbox changed, it will be killed and re-created.
  Normal   Pulling         30m (x3 over 31m)    kubelet, 1269k8s01000000  Pulling image "library/nginx:latest"
  Warning  Failed          30m (x3 over 31m)    kubelet, 1269k8s01000000  Failed to pull image "library/nginx:latest": rpc error: code = Unknown desc = no matching manifest for windows/amd64 10.0.17763 in the manifest list entries
  Warning  Failed          63s (x133 over 31m)  kubelet, 1269k8s01000000  Error: ImagePullBackOff

@mboersma
Copy link
Member Author

I think this broke because e2e tests use kubectl run and expect it to generate a deployment, which doesn't happen after kubernetes/kubernetes#87077 merged.

@mboersma mboersma force-pushed the add-k8s-1.18.0-alpha.3 branch from 347f7a2 to 83f3daf Compare February 19, 2020 21:43
@acs-bot acs-bot added size/L and removed size/XS labels Feb 19, 2020
Copy link
Member

@jackfrancis jackfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@acs-bot
Copy link

acs-bot commented Feb 19, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis, mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jackfrancis,mboersma]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mboersma mboersma merged commit 4afc2de into Azure:master Feb 19, 2020
@mboersma mboersma deleted the add-k8s-1.18.0-alpha.3 branch February 19, 2020 23:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants