This repository has been archived by the owner on Oct 24, 2023. It is now read-only.
test: HPA/cluster-autoscaler fixes so we don't scale up too many pods #2626
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
It seems that due to this issue our increase of node pools has revealed a bug in HPA, where it doesn't scale down if pods are Pending:
kubernetes/kubernetes#85506
This PR only calculates cluster-autoscaler-engaged node pools when determining how to configure HPA for scale up, so that there aren't Pending pods when we stop load.
Issue Fixed:
Requirements:
Notes: