Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

test: HPA/cluster-autoscaler fixes so we don't scale up too many pods #2626

Merged
merged 2 commits into from
Jan 25, 2020

Conversation

jackfrancis
Copy link
Member

Reason for Change:

It seems that due to this issue our increase of node pools has revealed a bug in HPA, where it doesn't scale down if pods are Pending:

kubernetes/kubernetes#85506

This PR only calculates cluster-autoscaler-engaged node pools when determining how to configure HPA for scale up, so that there aren't Pending pods when we stop load.

Issue Fixed:

Requirements:

Notes:

@acs-bot acs-bot added the size/S label Jan 24, 2020
@acs-bot
Copy link

acs-bot commented Jan 24, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jackfrancis jackfrancis changed the title E2e everything pre 1.14 test: HPA/cluster-autoscaler fixes so we don't scale up too many pods Jan 24, 2020
@codecov
Copy link

codecov bot commented Jan 24, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@a6e765e). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #2626   +/-   ##
=========================================
  Coverage          ?   71.83%           
=========================================
  Files             ?      131           
  Lines             ?    24844           
  Branches          ?        0           
=========================================
  Hits              ?    17847           
  Misses            ?     5970           
  Partials          ?     1027

@jackfrancis jackfrancis merged commit 9842c9a into Azure:master Jan 25, 2020
@jackfrancis jackfrancis deleted the e2e-everything-pre-1.14 branch January 25, 2020 02:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants