Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

test: consolidate E2E test cluster configurations #2586

Merged
merged 9 commits into from
Jan 22, 2020

Conversation

jackfrancis
Copy link
Member

@jackfrancis jackfrancis commented Jan 16, 2020

Reason for Change:

With the growing E2E test cluster configuration set, this PR is a consolidation of a few configs that can be tested as discrete node pools, and don't need a discrete cluster config.

Removed the following dedicated cluster configs:

  • GPU (moved to everything config as a dedicated node pool)
  • large VM SKU (moved to everything config as a dedicated node pool)
  • "not in VHD" (updated everything config to include component configuration not present in VHD)
  • ubuntu distro (moved to everything config as a dedicated node pool)
  • Windows custom VNET (created a Windows node pool the everything config, which is a custom VNET config)

Added a new cluster config:

  • zones (because we can no longer use availability zones in the everything config, as GPU VM SKU availability precludes zones support)

Overall this PR removes 4 cluster configs from the test matrix.

Issue Fixed:

Requirements:

Notes:

@acs-bot acs-bot added the size/L label Jan 16, 2020
@acs-bot
Copy link

acs-bot commented Jan 16, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Jan 16, 2020

Codecov Report

Merging #2586 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2586   +/-   ##
=======================================
  Coverage   71.79%   71.79%           
=======================================
  Files         131      131           
  Lines       24787    24787           
=======================================
  Hits        17795    17795           
  Misses       5966     5966           
  Partials     1026     1026

@acs-bot acs-bot added size/XL and removed size/L labels Jan 16, 2020
@jackfrancis jackfrancis force-pushed the e2e-consolidate-tests branch 2 times, most recently from 703aa04 to feae068 Compare January 21, 2020 21:37
@jackfrancis jackfrancis force-pushed the e2e-consolidate-tests branch from dfb9214 to 3aa01b3 Compare January 22, 2020 18:08
@jackfrancis jackfrancis merged commit a7c0390 into Azure:master Jan 22, 2020
@jackfrancis jackfrancis deleted the e2e-consolidate-tests branch January 23, 2020 18:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants