Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

feat: Adding WindowsNodeReset.ps1 script to reset/cleanup state for nodes #2457

Merged
merged 3 commits into from
Feb 18, 2020
Merged

feat: Adding WindowsNodeReset.ps1 script to reset/cleanup state for nodes #2457

merged 3 commits into from
Feb 18, 2020

Conversation

marosset
Copy link
Contributor

@marosset marosset commented Dec 13, 2019 •
edited
Loading

Reason for Change:

Issue Fixed:

Requirements:

Notes:

@marosset marosset requested a review from PatrickLang December 13, 2019 22:15
@acs-bot acs-bot added the size/L label Dec 13, 2019
@codecov
Copy link

codecov bot commented Dec 13, 2019 •
edited
Loading

Codecov Report

Merging #2457 into master will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2457   +/-   ##
=======================================
  Coverage   71.93%   71.93%           
=======================================
  Files         134      134           
  Lines       25097    25107   +10     
=======================================
+ Hits        18053    18061    +8     
- Misses       5988     5989    +1     
- Partials     1056     1057    +1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59c2ce0...38752c1. Read the comment docs.

@mboersma mboersma added this to the v0.46.0 milestone Dec 16, 2019
@marosset marosset closed this Dec 17, 2019
@marosset marosset deleted the windows-node-restart-script branch December 17, 2019 21:49
@marosset marosset restored the windows-node-restart-script branch December 19, 2019 21:52
@marosset marosset reopened this Dec 19, 2019
mboersma
mboersma previously approved these changes Dec 26, 2019
View reviewed changes
Copy link
Member

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but a Windows expert should also have a look.

@marosset marosset modified the milestones: v0.46.0, v0.47.0 Jan 7, 2020
@marosset
Copy link
Contributor Author

cc @ksubrmnn

ksubrmnn
ksubrmnn suggested changes Feb 3, 2020
View reviewed changes
Copy link
Contributor

@ksubrmnn ksubrmnn left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see anything egregious here, so you seem to be cleaning up the right things. Probably would need a bit more context to be 100%.
I'm not clear on how azure-cni is redeployed here (including ipam, etc). It's a bit different from Flannel which is what I'm used to.

parts/k8s/windowsnodereset.ps1 Outdated
}

#
# Create required networks
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would prefer more detailed comments. Not quite sure what the below section is supposed to be doing (from a newcomer's perspective)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the new context ok?

@jackfrancis jackfrancis modified the milestones: v0.47.0, Next Feb 4, 2020
@marosset marosset force-pushed the windows-node-restart-script branch from fc72cb3 to a7c5900 Compare February 10, 2020 18:53
@acs-bot
Copy link

acs-bot commented Feb 10, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: marosset

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@marosset marosset merged commit 8be7000 into Azure:master Feb 18, 2020
@marosset marosset deleted the windows-node-restart-script branch March 18, 2020 16:56
@fmotrifork fmotrifork mentioned this pull request Mar 23, 2020
Merged
bowen5 pushed a commit to bowen5/aks-engine that referenced this pull request Mar 31, 2020
@marosset @bowen5
feat: Adding WindowsNodeReset.ps1 script to reset/cleanup state for n…
acd323f 
…odes (Azure#2457)

* Adding WindowsNodeReset.ps1 script to reset/cleanup state for windox^C nodes

* fix linting errors

* fixing  comments per CR feedback

(cherry picked from commit 8be7000)
xuto2 pushed a commit that referenced this pull request Mar 31, 2020
@bowen5 @mboersma
@aramase @marosset
feat: cherry pick changes from master to support kubernetes 1.18 (#2996)
68206b8 
* feat: add support for Kubernetes 1.18.0-beta.1 (#2791)

* feat: add support for Kubernetes 1.18.0-beta.1

See https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG/CHANGELOG-1.18.md/#v1180-beta1

* fix: windows support .zip URL

(cherry picked from commit 34706cf)

* feat: add support for single stack IPv6 (#2781)

(cherry picked from commit 1b9beb4)

* feat: allow iptables mode for dualstack 1.18+ (#2882)


(cherry picked from commit ff5362e)

* chore: update cluster-autoscaler for k8s 1.18 (#2901)

See https://github.com/kubernetes/autoscaler/releases/tag/cluster-autoscaler-1.18.0

(cherry picked from commit 0cc985d)

* feat: add support for Kubernetes 1.18.0 (#2957)

See https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG-1.18.md

(cherry picked from commit 6dadaf0)

* test: fix test TestGetProvisionScriptParametersCommon and TestGetK8sVersionComponents

* feat: Adding WindowsNodeReset.ps1 script to reset/cleanup state for nodes (#2457)

* Adding WindowsNodeReset.ps1 script to reset/cleanup state for windox^C nodes

* fix linting errors

* fixing  comments per CR feedback

(cherry picked from commit 8be7000)

* feat: Experimental support for Windows+ContainerD (#1322)

(cherry picked from commit b068aa7)

* feat: installing csi-proxy for windows at node deployment time (#2930)

(cherry picked from commit 13e72f2)

Co-authored-by: Matt Boersma <[email protected]>
Co-authored-by: Anish Ramasekar <[email protected]>
Co-authored-by: Mark Rossetti <[email protected]>
bowen5 pushed a commit to bowen5/aks-engine that referenced this pull request Apr 16, 2020
@marosset @bowen5
feat: Adding WindowsNodeReset.ps1 script to reset/cleanup state for n…
974edc2 
…odes (Azure#2457)

* Adding WindowsNodeReset.ps1 script to reset/cleanup state for windox^C nodes

* fix linting errors

* fixing  comments per CR feedback

(cherry picked from commit 8be7000)
AbelHu pushed a commit to AbelHu/aks-engine that referenced this pull request Apr 21, 2020
@marosset @AbelHu
feat: Adding WindowsNodeReset.ps1 script to reset/cleanup state for n…
93bf304 
…odes (Azure#2457)

* Adding WindowsNodeReset.ps1 script to reset/cleanup state for windox^C nodes

* fix linting errors

* fixing  comments per CR feedback
andyliuliming pushed a commit that referenced this pull request Apr 21, 2020
@AbelHu @marosset
feat: Adding WindowsNodeReset.ps1 script to reset/cleanup state for n…
8bcc0d5 
…odes (#2457) (#3113)

* Adding WindowsNodeReset.ps1 script to reset/cleanup state for windox^C nodes

* fix linting errors

* fixing  comments per CR feedback

Co-authored-by: Mark Rossetti <[email protected]>
xuto2 pushed a commit that referenced this pull request Apr 22, 2020
@bowen5 @marosset
@mboersma @aramase @sozercan
feat: cherry pick changes from master to support kubernetes 1.18.1 (#…
3c6e785 
…3076)

* test: fix test TestGetK8sVersionComponents and TestGetProvisionScriptParametersCommon

* feat: Adding WindowsNodeReset.ps1 script to reset/cleanup state for nodes (#2457)

* Adding WindowsNodeReset.ps1 script to reset/cleanup state for windox^C nodes

* fix linting errors

* fixing  comments per CR feedback

(cherry picked from commit 8be7000)

* feat: add support for Kubernetes 1.18.0-beta.1 (#2791)

* feat: add support for Kubernetes 1.18.0-beta.1

See https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG/CHANGELOG-1.18.md/#v1180-beta1

* fix: windows support .zip URL

(cherry picked from commit 34706cf)

* feat: Experimental support for Windows+ContainerD (#1322)

(cherry picked from commit b068aa7)

* feat: add support for single stack IPv6 (#2781)

(cherry picked from commit 1b9beb4)

* feat: allow iptables mode for dualstack 1.18+ (#2882)


(cherry picked from commit ff5362e)

* chore: update cluster-autoscaler for k8s 1.18 (#2901)

See https://github.com/kubernetes/autoscaler/releases/tag/cluster-autoscaler-1.18.0

(cherry picked from commit 0cc985d)

* feat: installing csi-proxy for windows at node deployment time (#2930)

(cherry picked from commit 13e72f2)

* feat: add support for Kubernetes 1.18.0 (#2957)

See https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG-1.18.md

(cherry picked from commit 6dadaf0)

* fix: make build with go 1.14 (#3005)

(cherry picked from commit 509bc9c)

* feat: add support for Kubernetes 1.18.1 (#3045)

* feat: add support for Kubernetes 1.18.1

See https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG/CHANGELOG-1.18.md#changelog-since-v1180

* ci: test PRs with k8s 1.18

(cherry picked from commit 66ff61c)

Co-authored-by: Mark Rossetti <[email protected]>
Co-authored-by: Matt Boersma <[email protected]>
Co-authored-by: Anish Ramasekar <[email protected]>
Co-authored-by: Sertaç Özercan <[email protected]>
@AbelHu AbelHu mentioned this pull request Apr 22, 2020
Closed
4 tasks
AbelHu pushed a commit to AbelHu/aks-engine that referenced this pull request Apr 23, 2020
@marosset @AbelHu
feat: Adding WindowsNodeReset.ps1 script to reset/cleanup state for n…
e742d77 
…odes (Azure#2457)

* Adding WindowsNodeReset.ps1 script to reset/cleanup state for windox^C nodes

* fix linting errors

* fixing  comments per CR feedback
andyliuliming pushed a commit that referenced this pull request Apr 23, 2020
@AbelHu @marosset
@jaer-tsun @ksubrmnn
Update Windows VHD image to April release 4B 17763.1158.200421 (#3129)
f34eec4 
* feat: Adding WindowsNodeReset.ps1 script to reset/cleanup state for nodes (#2457)

* Adding WindowsNodeReset.ps1 script to reset/cleanup state for windox^C nodes

* fix linting errors

* fixing  comments per CR feedback

* chore: adding azure-cni v1.0.33 artifacts to VHDs (#2790)

* chore: update Azure CNI to v1.0.33 (#2825)

* feat: collect Windows CSE logs during log collection (#2858)

* fix: Windows no outbound fixes (#2883)

* fix: fixing nssm logging in windows CSE (#2890)

* fix: Get WindowsVersion from registry instead of calling Get-ComputerInfo (#2954)

* feat: adding kubelet and csi-proxy-server as windows defender excluded processes (#2967)

* feat: Updating AKS to use April 2020 Windows VHDs by default (#3060)

* feat: Updating Windows VHDs with 4B patches (#3115)

Co-authored-by: Mark Rossetti <[email protected]>
Co-authored-by: Jaeryn <[email protected]>
Co-authored-by: Kalya Subramanian <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mikkelhegn mikkelhegn mikkelhegn left review comments

@ksubrmnn ksubrmnn ksubrmnn requested changes

@mboersma mboersma mboersma left review comments

@PatrickLang PatrickLang Awaiting requested review from PatrickLang

Assignees

@PatrickLang PatrickLang

Labels
approved size/L windows
Projects
None yet
Milestone
Next
Development

Successfully merging this pull request may close these issues.
7 participants
@marosset @acs-bot @mboersma @mikkelhegn @ksubrmnn @jackfrancis @PatrickLang