fix: extend default value -1 for PodMaxPids for master and agentpool profile … #1623
Conversation
|
💖 Thanks for opening your first pull request! 💖 We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should make sure your first commit and PR title start with a semantic prefix. Examples of commit messages with semantic prefixes: - |
|
|
|
/azp run pr-e2e |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Codecov Report
@@ Coverage Diff @@
## master #1623 +/- ##
==========================================
+ Coverage 76.31% 76.38% +0.06%
==========================================
Files 129 129
Lines 18727 18721 -6
==========================================
+ Hits 14292 14300 +8
+ Misses 3652 3643 -9
+ Partials 783 778 -5 |
|
@TongChen15 can you please add more detail in the description to explain what was missing in #1508? |
|
/azp run pr-e2e |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: tonche If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/azp run pr-e2e |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ghost
merged commit
|
Congrats on merging your first pull request! 🎉🎉🎉 |
…profile … (#1623) * add default value -1 for PodMaxPids when supportPodPidsLimit feature gate is not set. * add default value -1 for PodMaxPids when supportPodPidsLimit feature gate is not set.
Reason for Change:
Previous fix didn't cover all cases. In the following issues reported by customer, even the Pod-Max-Pids is set to -1 when the SupportPodPidsLimit is not set, but that value in the agent pool profile is still original default value 100 which may still cause issue. Though we didn't observed issue for MasterProfile right now, we believe in some heavy load cluster, it may have potential issue with those CCP pods on master node. That's the reason why we should extend the fix#1508 to MasterProfile and AgentPoolProfile.
Issue Fixed:
Fixes #1270
Requirements:
Notes: