Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

Enable errcheck linter #1032

Closed
mboersma opened this issue Apr 11, 2019 · 1 comment · Fixed by #3184
Closed

Enable errcheck linter #1032

mboersma opened this issue Apr 11, 2019 · 1 comment · Fixed by #3184
Assignees
@mboersma
Labels
backlog help wanted

Comments

@mboersma
Copy link
Member

errcheck is enabled by default in golangci-lint, but we have it disabled for historical reasons. In Go, ignoring errors returned from a function is often a bug. This should be enabled as part of make test-style.
@mboersma mboersma mentioned this issue Apr 11, 2019
Closed
4 tasks
@mboersma mboersma mentioned this issue Apr 12, 2019
Merged
4 tasks
@stale
Copy link

stale bot commented Jun 11, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jun 11, 2019
@stale stale bot removed the stale label Jun 11, 2019
This was referenced May 2, 2020
Merged
Merged
@mboersma mboersma mentioned this issue May 4, 2020
Merged
4 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mboersma mboersma

Labels
backlog help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: check all error returns in main code mboersma/aks-engine
1 participant
@mboersma