Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove usage of module autorest/azure #256

Merged
merged 6 commits into from
Jun 5, 2024

Conversation

christinalau0
Copy link
Contributor

Reason for Change:

This PR removes the usage of module autorest/azure:

  1. It uses its own Environment structs in pkg/api/types.go.
  2. It removes the usage of helper method EnvironmentFromName.

Issue Fixed:

Credit Where Due:

Does this change contain code from or inspired by another project?

  • No
  • Yes

If "Yes," did you notify that project's maintainers and provide attribution?

  • No
  • Yes

Requirements:

Notes:

@christinalau0
Copy link
Contributor Author

Validated with obp pr-e2e pipeline.

cmd/root.go Outdated Show resolved Hide resolved
cmd/root.go Outdated Show resolved Hide resolved
@jadarsie jadarsie merged commit 6bc4f90 into Azure:master Jun 5, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants