Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use cloud controller manager in disconnected pipeline #165

Merged

Conversation

christinalau0
Copy link
Contributor

@christinalau0 christinalau0 commented Jul 24, 2023

Reason for Change:

  • Set useCloudControllerManager=true in disconnected api model
  • Allow access to arm service tag in nsg for disconnected scenario
  • Disable azure file csi driver addon
  • Add nginx image to vhd for pvc test in disconnected

Issue Fixed:

Credit Where Due:

Does this change contain code from or inspired by another project?

  • No
  • Yes

If "Yes," did you notify that project's maintainers and provide attribution?

  • No
  • Yes

Requirements:

Notes:

- Set useCloudControllerManager=true in api model
- Allow access to arm service tag in nsg for disconnected scenario
- Disable azure file csi driver addon
- Remove azure file csi driver storage class test
- Disable pvc test in disconnected since it requires nginx image
@christinalau0
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jadarsie
Copy link
Member

Disable pvc test in disconnected since it requires nginx image

I am not sure about this. Can we get the same coverage using a different image?

@christinalau0
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@christinalau0
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

test/e2e/kubernetes/kubernetes_test.go Outdated Show resolved Hide resolved
test/e2e/kubernetes/kubernetes_test.go Outdated Show resolved Hide resolved
@jadarsie
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@christinalau0 christinalau0 merged commit 93131d8 into Azure:master Jul 25, 2023
@christinalau0 christinalau0 deleted the disconnected-cloudcontrollermanager branch July 25, 2023 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants