-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: use cloud controller manager in disconnected pipeline #165
Merged
christinalau0
merged 5 commits into
Azure:master
from
christinalau0:disconnected-cloudcontrollermanager
Jul 25, 2023
Merged
ci: use cloud controller manager in disconnected pipeline #165
christinalau0
merged 5 commits into
Azure:master
from
christinalau0:disconnected-cloudcontrollermanager
Jul 25, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Set useCloudControllerManager=true in api model - Allow access to arm service tag in nsg for disconnected scenario - Disable azure file csi driver addon - Remove azure file csi driver storage class test - Disable pvc test in disconnected since it requires nginx image
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
I am not sure about this. Can we get the same coverage using a different image? |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
jadarsie
reviewed
Jul 25, 2023
jadarsie
reviewed
Jul 25, 2023
jadarsie
approved these changes
Jul 25, 2023
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Issue Fixed:
Credit Where Due:
Does this change contain code from or inspired by another project?
If "Yes," did you notify that project's maintainers and provide attribution?
Requirements:
Notes: