Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: addpool generates prefixes based on pool count #138

Merged
merged 1 commit into from
May 11, 2023

Conversation

jadarsie
Copy link
Member

Reason for Change:

Adding multiple Windows node pools using aks-engine-azurestack addpool results in conflicting VM names. This fix ensure that the VM name prefixes differ.

Issue Fixed:

Fixes #136

@jadarsie jadarsie requested a review from christinalau0 May 10, 2023 20:41
@jadarsie
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

@christinalau0 christinalau0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jadarsie jadarsie merged commit 2cabf84 into Azure:master May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

addpool on windows always uses VMNamePrefix s00
2 participants