Support for TLS Functionality with Gateway API via Workload Identity #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaiveerk
changed the title
OliverMKing
reviewed
Oct 28, 2024
OliverMKing
reviewed
Oct 28, 2024
OliverMKing
reviewed
Oct 28, 2024
OliverMKing
reviewed
Oct 28, 2024
OliverMKing
reviewed
Oct 28, 2024
OliverMKing
reviewed
Oct 28, 2024
OliverMKing
reviewed
Oct 28, 2024
OliverMKing
reviewed
Oct 28, 2024
OliverMKing
reviewed
Oct 28, 2024
OliverMKing
reviewed
Oct 28, 2024
OliverMKing
reviewed
Oct 29, 2024
OliverMKing
reviewed
Oct 29, 2024
OliverMKing
reviewed
Oct 29, 2024
OliverMKing
reviewed
Oct 29, 2024
OliverMKing
reviewed
Oct 29, 2024
OliverMKing
reviewed
Oct 29, 2024
|
/ok-to-test sha=03d8910 |
|
/ok-to-test sha=0474374 |
|
/ok-to-test sha=908e6c3 |
OliverMKing
reviewed
Nov 14, 2024
OliverMKing
reviewed
Nov 14, 2024
|
|
||
| if listenerIsKvEnabled(listener) { | ||
| var clientId string | ||
| clientId, err = retrieveClientIdFromListener(ctx, g.client, req.Namespace, listener.TLS.Options) |
There was a problem hiding this comment.
the client id should come from the SA.
We need some way of triggering a reconcile if the SA changes their client id too
There was a problem hiding this comment.
done via sa indexer
OliverMKing
reviewed
Nov 14, 2024
| } | ||
|
|
||
| gateways := &gatewayv1.GatewayList{} | ||
| err := mgr.GetClient().List(context.TODO(), gateways, client.MatchingFields{serviceAccountIndexName: sa.Name}) |
There was a problem hiding this comment.
need to consider namespaces
OliverMKing
reviewed
Nov 14, 2024
|
|
||
| saSet := map[string]struct{}{} | ||
|
|
||
| for _, listener := range gateway.Spec.Listeners { |
There was a problem hiding this comment.
need to consider namespaces
There was a problem hiding this comment.
we consider namespaces when requeuing requests for Gateways - see line 60.
All we can do within this function is pull names from the Gateway resources - verification via the client naturally happens when we're grabbing the actual gateways tied to each serviceaccount
|
/ok-to-test sha=2c034aa |
jaiveerk
changed the title
jaiveerk
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for a managed TLS experience with the Gateway API via workload identity.
Fixes # (issue)
Feature # (details)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Unit tests. e2e tests will be added after DNS functionality has been merged.
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration. Is it a breaking change which will impact consuming tool(s)?
Checklist: