Skip to content
This repository has been archived by the owner on Jan 11, 2023. It is now read-only.

Cluster definition docs cleanup #2622

Merged
merged 6 commits into from
Apr 6, 2018
Merged

Conversation

CecileRobertMichon
Copy link
Contributor

@CecileRobertMichon CecileRobertMichon commented Apr 6, 2018

What this PR does / why we need it: First attempt to make docs more consistent.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

If applicable:

  • documentation
  • unit tests
  • tested backward compatibility (ie. deploy with previous version, upgrade with this branch)

Release note:

@ghost ghost added the in progress label Apr 6, 2018
@@ -544,15 +545,15 @@ For apiVersion "2016-03-30", a cluster may have only 1 agent pool profiles.
|---|---|---|
|clientAppID|yes|describes the client AAD application ID|
|serverAppID|yes|describes the server AAD application ID|
|tenantID|no|describes the AAD tenant ID to use for authentication. If not specified, will use the tenant of the deployment subscription.|
|tenantID|no|describes the AAD tenant ID to use for authentication. If not specified, will use the tenant of the deployment subscription|
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/describes/Describes

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

jackfrancis
jackfrancis previously approved these changes Apr 6, 2018
Copy link
Member

@jackfrancis jackfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one comment, otherwise looks great!

@jackfrancis jackfrancis merged commit 2d32f70 into Azure:master Apr 6, 2018
@ghost ghost removed the in progress label Apr 6, 2018
@CecileRobertMichon CecileRobertMichon deleted the docs branch April 16, 2018 17:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants