This repository has been archived by the owner on Jan 11, 2023. It is now read-only.
simplify code and turn on more linters #2433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Things that were simplified: - a lot of returns can be simplified to return the error early - checking of bools can be done with a bang (!) instead of == false, etc - remove some dead code Signed-off-by: Jess Frazelle <[email protected]>
ghost
assigned 
jackfrancis
reviewed
Mar 12, 2018
| @@ -353,12 +352,15 @@ func (sc *scaleCmd) run(cmd *cobra.Command, args []string) error { | |||
| } | |||
| var apiVersion string | |||
| sc.containerService, apiVersion, err = apiloader.LoadContainerServiceFromFile(sc.apiModelPath, false, true, nil) | |||
| if err != nil { | |||
There was a problem hiding this comment.
So actually doing something with this err makes perfect sense. @amanohar @dmitsh could you take a look at this code and make sure that there isn't a reason why we actually want to absorb this error no matter what? (in which case we should throw away the err reference and replace with _).
I mean, we definitely want to not ignore errors, but if doing so in this scale code actually breaks something holistically, we want to know about it so that we can fix the entire stack.
jackfrancis
reviewed
Mar 12, 2018
| @@ -824,7 +824,7 @@ func assignDefaultAddonVals(addon, defaults api.KubernetesAddon) api.KubernetesA | |||
| } | |||
| for key, val := range defaults.Config { | |||
| if addon.Config == nil { | |||
| addon.Config = make(map[string]string, 0) | |||
| addon.Config = make(map[string]string) | |||
jackfrancis
reviewed
Mar 12, 2018
| @@ -854,8 +854,7 @@ func addDefaultFeatureGates(m map[string]string, version string, minVersion stri | |||
| } | |||
|
|
|||
| func combineValues(inputs ...string) string { | |||
| var valueMap map[string]string | |||
| valueMap = make(map[string]string) | |||
| valueMap := make(map[string]string) | |||
dmitsh
approved these changes
Mar 14, 2018
tesharp
pushed a commit
to tesharp/acs-engine
that referenced
this pull request
Mar 16, 2018
Things that were simplified: - a lot of returns can be simplified to return the error early - checking of bools can be done with a bang (!) instead of == false, etc - remove some dead code Signed-off-by: Jess Frazelle <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things that were simplified: