Skip to content
This repository has been archived by the owner on Jan 11, 2023. It is now read-only.

deal with backtick (`) chars in sp keys #3038

Closed
jackfrancis opened this issue May 22, 2018 · 1 comment · Fixed by #3919
Closed

deal with backtick (`) chars in sp keys #3038

jackfrancis opened this issue May 22, 2018 · 1 comment · Fixed by #3919
Labels
good first issue kind/chore

Comments

@jackfrancis
Copy link
Member

Exact details TBD, but from a high level we should either fail validation or escape backticks. Observation suggests that currently we're not dealing with it at all which yields non-deterministic side-effects during deployment.
@CecileRobertMichon
Copy link
Contributor

Right now we have single quotes around it to allow special characters #2255 but not sure how we can deal with ` characters

@tariq1890 tariq1890 mentioned this issue Sep 28, 2018
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
good first issue kind/chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow service principals with double-quote (") and backslash (\) tariq1890/acs-engine
2 participants
@jackfrancis @CecileRobertMichon