Skip to content
This repository was archived by the owner on Jan 11, 2023. It is now read-only.

404 in link on https://github.com/Azure/acs-engine/blob/master/docs/swarmmode.md #2981

Closed
JoranDox opened this issue May 16, 2018 · 3 comments · Fixed by #3019
Closed

Comments

@JoranDox
Copy link

Is this a request for help?:

Yes, I think?


Is this an ISSUE or FEATURE REQUEST? (choose one):

Issue.


What version of acs-engine?:

The documentation on github, at the point of this commit: bfc9c7e


Orchestrator and version (e.g. Kubernetes, DC/OS, Swarm)

N/A

What happened:

I clicked a link and it gave me a 404 error.
( point 5 in https://github.com/Azure/acs-engine/blob/master/docs/swarmmode.md : "deploy the output azuredeploy.json and azuredeploy.parameters.json" , linking here: https://github.com/Azure/acs-engine/blob/master/acsengine.md#deployment-usage )

What you expected to happen:

To see the correct information linked.

How to reproduce it (as minimally and precisely as possible):

Go to the linked page and click the link.

Anything else we need to know:

N/A

@JoranDox
Copy link
Author

For the record, on the same page, link 4 doesn't work exactly either, it links to https://github.com/Azure/acs-engine/blob/master/docs/acsengine.md#generating-a-template , but #generating-a-template doesn't exist, it's been renamed or moved to https://github.com/Azure/acs-engine/blob/master/docs/acsengine.md#generate-templates

@JoranDox
Copy link
Author

from a different (working) link I noticed that it should be:
https://github.com/Azure/acs-engine/blob/master/docs/acsengine.md#deployment-usage

(notice the added /docs/ in the middle)

if someone could fix this (and search the repo for references before changing links like that) that would be great, thanks!

@CecileRobertMichon
Copy link
Contributor

@NightFantomJ2 feel free to open a PR to fix it if you're interested in contributing!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants