Skip to content
This repository was archived by the owner on Jan 11, 2023. It is now read-only.

Deploy using client-id and client-secret command line switches throws an error #2933

Closed
maniSbindra opened this issue May 12, 2018 · 2 comments
Assignees

Comments

@maniSbindra
Copy link
Contributor

Is this a request for help?: No


Is this an ISSUE or FEATURE REQUEST? (choose one): Issue


What version of acs-engine?: Building against current commit
./bin/acs-engine version. Realised this when trying to fix issue 2728

(Version: canary
GitCommit: 5e0ff5b
GitTreeState: dirty)

Orchestrator and version (e.g. Kubernetes, DC/OS, Swarm) Kubernetes

What happened: same as #2657, I have added comments against PR #2771 which may have caused the issue to reoccur.

What you expected to happen: same as #2657, I have added comments against PR #2771 which may have caused the issue to reoccur.

How to reproduce it (as minimally and precisely as possible): same as #2657, I have added comments against PR #2771 which may have caused the issue to reoccur.

Anything else we need to know: same as #2657, I have added comments against PR #2771 which may have caused the issue to reoccur.

@CecileRobertMichon
Copy link
Contributor

@maniSbindra good catch! We will need to change the change the logic to either a) allow empty client id/secret in validation, b) fill in the apimodel with the values before we validate it or c) load the CS without validation and run a validation later after filling in values from the command line. I personally prefer option c) if we can get it work.

@stale
Copy link

stale bot commented Mar 9, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contribution. Note that acs-engine is deprecated--see https://github.com/Azure/aks-engine instead.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants