sFlow High Level Design #389
Conversation
doc/sflow/sflow_hld.md
Outdated
|
|
||
| ### Not planned to be supported: | ||
| 1. sFlow enable/disable option interface level as well as global level. | ||
| 2. sFlow configuration at interface level. |
There was a problem hiding this comment.
why do we have such limitation?
There was a problem hiding this comment.
Updated HLD. This will be supported.
doc/sflow/sflow_hld.md
Outdated
| ; Defines schema for SFLOW_TABLE table which contains parameters that need to be set for sFlow | ||
| key = SFLOW_TABLE:sflow | ||
| ; field = value | ||
| sampling_rate = 1*5DIGIT ; 1 / (sflow sampling rate as a percentage of bandwidth) |
There was a problem hiding this comment.
this is unclear to me. what does 1 mean here? does it mean we sample every packet?
There was a problem hiding this comment.
Update definition of sampling rate (it is as per the SAI definition).
doc/sflow/sflow_hld.md
Outdated
|
|
||
|
|
||
| ### **Phase II:** | ||
| 1. sFlow should be supported on portchannel interfaces. |
There was a problem hiding this comment.
do you support break-out interfaces? Is there any hsflowd limitation to support breakouts?
There was a problem hiding this comment.
break-out interfaces are not currently supported.
| * The host-sflow package will be built with the mod_sonic callback implementations using the FEATURES="SONIC" option | ||
|
|
||
| ## 9 **Restrictions** | ||
| * /etc/hsflowd.conf should not be modified manually. While it should be possible to change /etc/hsflowd.conf manually and restart the sflow container, it is not recommended. |
There was a problem hiding this comment.
is there any hsflowd/InMon license implications? Community interested to learn on the implications if any.
There was a problem hiding this comment.
|
|
||
| #### hsflowd service | ||
|
|
||
| hsflowd provides an module adaptation layer for interfacing with the NOS. In the host-sflow repo, a src/Linux/mod_sonic.c adaption layer will be provided for hsflowd APIs to SONiC that deal with hsflowd initialization, configuration changes, packet sample consumption etc. More specifically, SONiC will register and provide callbacks for the following HSP events: |
There was a problem hiding this comment.
What is the configurations need to expose hsflowd/InMon ? If user wanted to expose some custom configuration such as sampling rate what is the strategy, where do maintain the custom configurations? is it in SONiC Repo or hsflowd/InMon Repos?
There was a problem hiding this comment.
Collector and agent specific configurations are available in the configDB and host-sflow will have a mod_sonic that is customised to interact with SONiC (essentially query the DB). If there are new customizations, we publish the changes in SONiC schema and mod_sonic will have to be updated (in host-sflow repo) to provide the necessary functionality.
|
Netlink message can not be received by hsflowd, and the psamle driver returns -ESRCH while broadcasting message to userspace by |
Can you please raise an issue to sonic-builidimage? Also with configs/step to reproduce etc. |
Thank you for replying, finally I solved the problem, which was caused by the network mode of sflow docker. After restarting sflow docker with host network mode, everything went well, thanks again. |
This document describes the high level design of sFlow in SONiC.