Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VNET: Removed requirement for default subnet #930

Merged
merged 1 commit into from
Jan 26, 2022
Merged

VNET: Removed requirement for default subnet #930

merged 1 commit into from
Jan 26, 2022

Conversation

AlexanderSehr
Copy link
Contributor

@AlexanderSehr AlexanderSehr commented Jan 26, 2022 •
edited
Loading

Change

  • It's actually not required to deploy a subnet in a VNET (and there are cases were we don't want to deploy one). Hence I removed the requirement

Pipeline reference:
Network: VirtualNetworks

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update (Wiki)

@AlexanderSehr AlexanderSehr self-assigned this Jan 26, 2022
@AlexanderSehr AlexanderSehr added [cat] modules category: modules bug Something isn't working and removed bug Something isn't working labels Jan 26, 2022
@AlexanderSehr AlexanderSehr added this to the v 0.4 milestone Jan 26, 2022
@AlexanderSehr AlexanderSehr merged commit 4d371fc into main Jan 26, 2022
@AlexanderSehr AlexanderSehr deleted the users/alsehr/vnetDefaultSubnet branch January 26, 2022 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rahalan rahalan rahalan approved these changes

Assignees

@AlexanderSehr AlexanderSehr

Labels
[cat] modules category: modules
Projects
None yet
Milestone
v 0.4
Development

Successfully merging this pull request may close these issues.
2 participants
@AlexanderSehr @rahalan