Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added sql database module #93

Merged
merged 5 commits into from
Oct 3, 2021

Conversation

AlexanderSehr
Copy link
Contributor

Change

  • Translated SQL database template to bicep
  • Removed original ARM file
  • Added a few additional paramters
  • Removed endpoint implementation

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update (Wiki)

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@AlexanderSehr AlexanderSehr enabled auto-merge (squash) October 2, 2021 21:39
@AlexanderSehr AlexanderSehr merged commit aa48a94 into main Oct 3, 2021
Copy link
Contributor

@eriqua eriqua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Opened a new PBI to add missing PE

@AlexanderSehr AlexanderSehr deleted the users/alsehr/bicep_sqlServerDatabase branch October 4, 2021 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants