Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mapping module deployment outputs to github action output #878

Merged
merged 21 commits into from
Jan 13, 2022

Conversation

eriqua
Copy link
Contributor

@eriqua eriqua commented Jan 11, 2022

Change

Mapping the module deployment output to a validation deployment github action output variable.
The key-value pairs are converted to a single json string.
This small change will allow us to leverage module deployment outputs from any workflow using the action e.g. the dependency pipeline or solutions using a pipeline orchestrated approach.
Can also be leveraged to use deployment outputs as input for subsequent jobs.

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update (Wiki)

Checklist

  • [] I'm sure there are no other open Pull Requests for the same update/change
  • [] My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@eriqua eriqua added the [cat] pipelines category: pipelines label Jan 11, 2022
@eriqua eriqua added this to the v 0.4 milestone Jan 11, 2022
@eriqua eriqua self-assigned this Jan 11, 2022
Copy link
Contributor

@AlexanderSehr AlexanderSehr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any changes required for the AzureDevOps templates too?

@eriqua
Copy link
Contributor Author

eriqua commented Jan 12, 2022

Any changes required for the AzureDevOps templates too?

Agree, working on it

@eriqua eriqua marked this pull request as draft January 12, 2022 12:18
@eriqua eriqua marked this pull request as ready for review January 13, 2022 09:37
@eriqua eriqua added the [cat] azure devops category: Azure DevOps label Jan 13, 2022
@AlexanderSehr AlexanderSehr self-requested a review January 13, 2022 10:15
@eriqua eriqua merged commit c3f451a into main Jan 13, 2022
@AlexanderSehr AlexanderSehr deleted the users/erikag/action-output branch January 13, 2022 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[cat] azure devops category: Azure DevOps [cat] pipelines category: pipelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants