-
Notifications
You must be signed in to change notification settings - Fork 453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Missing Diagnostic Settings to Modules #765
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @senavar, any chance you tested the code in pipelines? If so, could you do me a favor and add the pipeline badges to your PR summary for the pipelines to which you added the diagnostic settings?
This comment has been minimized.
This comment has been minimized.
Unit Test Results 1 files ± 0 1 suites ±0 19s ⏱️ +5s Results for commit 1d50d3d. ± Comparison against base commit d13ae5d. This pull request removes 4 and adds 32 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
Change
Updated the Log Analytics, SQL DB, and Storage Account modules to allow for the configuration of diagnostic settings
Type of Change
Please delete options that are not relevant.
Checklist