Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align RBAC on Microsoft.NetApp #389

Merged
merged 1 commit into from
Nov 4, 2021
Merged

Conversation

MariusStorhaug
Copy link
Contributor

Change

  • Moved builtInRoleNames variable to .bicep/nested_rbac.json
  • Using declaration of existing resource + scope reference in roleAssignment resource declaration
  • Updated Readme

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update (Wiki)

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@MariusStorhaug MariusStorhaug self-assigned this Nov 4, 2021
@MariusStorhaug MariusStorhaug enabled auto-merge (squash) November 4, 2021 08:30
@MariusStorhaug MariusStorhaug merged commit 0cb608a into main Nov 4, 2021
@AlexanderSehr AlexanderSehr deleted the users/mast/MS.NetApp_RBAC branch November 4, 2021 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants