-
Notifications
You must be signed in to change notification settings - Fork 456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Modules] Align CMK implementation for Cognitive Services & cleaned up several allowed values #2402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexanderSehr
added
enhancement
New feature or request
[cat] modules
category: modules
labels
Dec 2, 2022
Test Results 1 files ± 0 1 suites ±0 41s ⏱️ ±0s Results for commit 42a981e. ± Comparison against base commit 918b08f. This pull request removes 52 and adds 55 tests. Note that renamed tests count towards both.
This pull request removes 2 skipped tests and adds 1 skipped test. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
eriqua
reviewed
Dec 3, 2022
modules/Microsoft.CognitiveServices/accounts/.test/common/deploy.test.bicep
Outdated
Show resolved
Hide resolved
AlexanderSehr
changed the title
[Modules] Align CMK implementation for Cognitive Services
[Modules] Align CMK implementation for Cognitive Services & cleaned up several allowed values
Dec 4, 2022
eriqua
reviewed
Dec 4, 2022
eriqua
reviewed
Dec 4, 2022
eriqua
reviewed
Dec 4, 2022
Co-authored-by: Erika Gressi <[email protected]>
Co-authored-by: Erika Gressi <[email protected]>
eriqua
approved these changes
Dec 9, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🆗
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Pipeline references
Type of Change
Please delete options that are not relevant.