Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Utilities] Increased flexibility on parameter table search #2133

Merged
merged 3 commits into from
Sep 25, 2022
Merged

[Utilities] Increased flexibility on parameter table search #2133

merged 3 commits into from
Sep 25, 2022

Conversation

AlexanderSehr
Copy link
Contributor

@AlexanderSehr AlexanderSehr commented Sep 25, 2022 •
edited
Loading

Description

  • Increased flexibility on parameter table search (i.e., search for the start of the table instead of assuming it's 'just' in the next line)

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline
AnalysisServices: Servers

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to documentation

@AlexanderSehr AlexanderSehr changed the title Users/alsehr/read me test follow up [Utilities] Increased flexibility on parameter table search Sep 25, 2022
@AlexanderSehr AlexanderSehr added [cat] testing category: testing enhancement New feature or request labels Sep 25, 2022
@github-actions
Copy link

Unit Test Results

  1 files  ±    0    1 suites  ±0   24s ⏱️ - 1m 52s
53 tests  - 297  53 ✔️  - 291  0 💤  - 6  0 ❌ ±0 
55 runs   - 296  55 ✔️  - 290  0 💤  - 6  0 ❌ ±0 

Results for commit f74fb80. ± Comparison against base commit 5ad973d.

This was referenced Sep 25, 2022
Merged
Merged
@AlexanderSehr AlexanderSehr marked this pull request as ready for review September 25, 2022 09:19
@AlexanderSehr AlexanderSehr requested a review from a team as a code owner September 25, 2022 09:19
@AlexanderSehr AlexanderSehr enabled auto-merge (squash) September 25, 2022 09:19
MariusStorhaug
MariusStorhaug approved these changes Sep 25, 2022
View reviewed changes
Copy link
Contributor

@MariusStorhaug MariusStorhaug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a good approach ye.

@AlexanderSehr AlexanderSehr merged commit e0b9070 into main Sep 25, 2022
@AlexanderSehr AlexanderSehr deleted the users/alsehr/readMeTestFollowUp branch September 25, 2022 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MariusStorhaug MariusStorhaug MariusStorhaug approved these changes

Assignees

@AlexanderSehr AlexanderSehr

Labels
[cat] testing category: testing enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlexanderSehr @MariusStorhaug